Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Fix wrong spelling 'initiaGlobals' #28616

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Jul 16, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

This pull request updates the MIGRATION.md file to provide comprehensive guidance for upgrading from Storybook 7.x to 8.0, covering significant changes and breaking updates.

  • Drops support for Node.js 16 and Yarn 1, requiring users to update their development environments
  • Removes the storyshots addon, necessitating alternative testing strategies
  • Modifies UI layout state shape and updates Button and IconButton components, potentially affecting custom themes
  • Deprecates the Icons component in favor of @storybook/icons, requiring updates to icon usage
  • Changes story extraction behavior, which may impact how stories are discovered and loaded

@valentinpalkovic valentinpalkovic self-assigned this Jul 16, 2024
@valentinpalkovic valentinpalkovic added documentation ci:docs Run the CI jobs for documentation checks only. labels Jul 16, 2024
Copy link

nx-cloud bot commented Jul 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f7cebb6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@valentinpalkovic valentinpalkovic added ci:docs Run the CI jobs for documentation checks only. and removed ci:docs Run the CI jobs for documentation checks only. labels Aug 6, 2024
@valentinpalkovic valentinpalkovic marked this pull request as ready for review August 6, 2024 08:49
@valentinpalkovic valentinpalkovic merged commit 43e9223 into next Aug 6, 2024
3 checks passed
@valentinpalkovic valentinpalkovic deleted the valentin/fix-migration branch August 6, 2024 08:49
@valentinpalkovic valentinpalkovic changed the title Update MIGRATION.md Docs: Update Migration.md Aug 6, 2024
@valentinpalkovic valentinpalkovic changed the title Docs: Update Migration.md Docs: Fix wrong spelling 'initiaGlobals' Aug 6, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@github-actions github-actions bot mentioned this pull request Aug 6, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:docs Run the CI jobs for documentation checks only. documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant