-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Telemetry: Add mount, beforeEach, moduleMock stats #28624
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4bc40ae. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not sure if we can make the regexp slighly tighter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
- Added telemetry tracking for
mount
,beforeEach
, andmoduleMock
in/code/core/src/csf-tools/CsfFile.ts
- Updated tests to cover new telemetry features in
/code/core/src/csf-tools/CsfFile.test.ts
- Enhanced telemetry data capture in
/code/core/src/core-server/utils/StoryIndexGenerator.test.ts
- Modified
IndexInputStats
interface to include new telemetry properties in/code/core/src/types/modules/indexer.ts
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Telemetry: Add mount, beforeEach, moduleMock stats (cherry picked from commit 42f8d8f)
Closes N/A
Telescopes on #28622
What I did
Add stats on CSF feature usage
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Run a sandbox with STORYBOOK_TELEMETRY_DEBUG=1 and observe the payload with the number of mount/beforeEach/moduleMock counts when you use those CSF features.
🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>