Next.js: Add @storybook/experimental-nextjs-vite package #28800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d1ed7ba. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
valentinpalkovic
changed the title
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
30 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
code/frameworks/nextjs-vite/src/routing/app-router-provider.tsx
Outdated
Show resolved
Hide resolved
valentinpalkovic
requested review from
kylegach and
jonniebigodes
as code owners
ndelangen
reviewed
Aug 5, 2024
ndelangen
reviewed
Aug 5, 2024
ndelangen
reviewed
Aug 5, 2024
- Use a more stable heading
- "Experimental" is temporary
- Update package names
jonniebigodes
approved these changes
Aug 5, 2024
valentinpalkovic
force-pushed
the
valentin/nextjs-vite
branch
from
5a5e1d9
to
3257177
Compare
valentinpalkovic
added
ci:daily
29 tasks
valentinpalkovic
changed the title
This was referenced Oct 3, 2024
This was referenced Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28799
What I did
I have created a new experimental
@storybook/experimental-nextjs-vitepackage, based on Vite andvite-plugin-storybook-nextjsChecklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This pull request has been released as version
0.0.0-pr-28800-sha-2528064a. Try it out in a new sandbox by runningnpx storybook@0.0.0-pr-28800-sha-2528064a sandboxor in an existing project withnpx storybook@0.0.0-pr-28800-sha-2528064a upgrade.More information
0.0.0-pr-28800-sha-2528064avalentin/nextjs-vite2528064a1722724484)To request a new release of this pull request, mention the
@storybookjs/coreteam.core team members can create a new canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=28800Greptile Summary
The pull request introduces a new experimental
@storybook/nextjs-vitepackage, integrating Vite with Next.js for Storybook.nextjs-vitetoframework-to-renderer.ts,versions.ts, andframeworks.tsto map it to thereactrenderer..eslintrc.json,README.md,package.json,preset.js, andproject.jsonfor thenextjs-viteframework.src/export-mocks.src.types.tsandtypings.d.ts.Ensure all dependencies and configurations are correctly set up and thoroughly tested.