Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Revert bad lockfile changes #28824

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 7, 2024

Closes N/A

What I did

Reverts some unintended lockfile changes from #26764

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 20 B 0.91 0%
initSize 184 MB 171 MB -13 MB -0.99 -7.6%
diffSize 108 MB 95 MB -13 MB -0.99 -13.7%
buildSize 7.42 MB 7.42 MB 0 B -1.73 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B -1.69 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.29 MB 2.29 MB 0 B -0.9 0%
buildSbPreviewSize 351 kB 351 kB 0 B 0.42 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.45 MB 4.45 MB 0 B -1.61 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -1.73 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 24.7s 23.5s -1s -239ms 1.1 -5.3%
generateTime 19.5s 22.3s 2.7s 0.07 12.3%
initTime 18.1s 20.3s 2.2s -0.32 10.8%
buildTime 14.4s 12.4s -1s -963ms -1.45 🔰-15.7%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8.3s 10.9s 2.6s 1.73 🔺24.3%
devManagerResponsive 5.3s 6.4s 1.1s 1.5 🔺17.4%
devManagerHeaderVisible 845ms 900ms 55ms 0.22 6.1%
devManagerIndexVisible 893ms 943ms 50ms 0.26 5.3%
devStoryVisibleUncached 1.1s 1.4s 316ms 1.18 21.4%
devStoryVisible 921ms 968ms 47ms 0.24 4.9%
devAutodocsVisible 713ms 850ms 137ms 0.79 16.1%
devMDXVisible 837ms 864ms 27ms 1.08 3.1%
buildManagerHeaderVisible 763ms 817ms 54ms 0.21 6.6%
buildManagerIndexVisible 766ms 864ms 98ms 0.56 11.3%
buildStoryVisible 813ms 875ms 62ms 0.23 7.1%
buildAutodocsVisible 719ms 917ms 198ms 2.29 🔺21.6%
buildMDXVisible 707ms 686ms -21ms -0.09 -3.1%

Greptile Summary

Reverted unintended lockfile changes from PR #26764, with minor modifications to utility functions in snapshot files.

  • Modified _defineProperty function in code/renderers/react/template/stories/docgen-components/8428-js-static-prop-types/docgen.snapshot for improved readability and performance.
  • Updated _extends function in code/renderers/react/template/stories/docgen-components/9556-ts-react-default-exports/docgen.snapshot with a new variable naming convention and structure.
  • Ensured no changes to React component definitions or PropTypes in both files.
  • Verified no security issues or logical errors introduced by these changes.

@shilman shilman added build Internal-facing build tooling & test updates ci:normal labels Aug 7, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Aug 7, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit b3880d7. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@shilman shilman merged commit 9d48cd5 into next Aug 7, 2024
53 of 57 checks passed
@shilman shilman deleted the shilman/revert-lockfile-changes branch August 7, 2024 07:43
@github-actions github-actions bot mentioned this pull request Aug 7, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant