Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linting: Formatting fixes on next #28854

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 9, 2024

What I did

Found some things, not formatted well.

I fixed them.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B -1.09 0%
initSize 167 MB 167 MB 0 B -0.79 0%
diffSize 91.1 MB 91.1 MB 0 B -0.78 0%
buildSize 7.42 MB 7.42 MB 0 B -0.23 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B -0.23 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.29 MB 2.29 MB 0 B 4.36 0%
buildSbPreviewSize 351 kB 351 kB 0 B -4.36 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.45 MB 4.45 MB 0 B -0.23 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -0.23 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.3s 6.1s -200ms -2.44 -3.3%
generateTime 21.5s 18.2s -3s -321ms -1.2 -18.2%
initTime 18.5s 16.3s -2s -220ms -1.4 🔰-13.6%
buildTime 11.7s 10.9s -790ms -1.59 🔰-7.2%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 8.8s 10s 1.1s 1.08 11.8%
devManagerResponsive 5.3s 5.8s 477ms 0.9 8.2%
devManagerHeaderVisible 773ms 1.1s 404ms 3.4 🔺34.3%
devManagerIndexVisible 781ms 1.2s 433ms 3.43 🔺35.7%
devStoryVisibleUncached 1.2s 1.6s 384ms 2.17 🔺23.3%
devStoryVisible 814ms 1.2s 445ms 3.56 🔺35.3%
devAutodocsVisible 682ms 923ms 241ms 2.01 🔺26.1%
devMDXVisible 736ms 1.1s 369ms 4.21 🔺33.4%
buildManagerHeaderVisible 713ms 942ms 229ms 1.69 🔺24.3%
buildManagerIndexVisible 722ms 994ms 272ms 2.14 🔺27.4%
buildStoryVisible 757ms 992ms 235ms 1.61 🔺23.7%
buildAutodocsVisible 640ms 934ms 294ms 2.47 🔺31.5%
buildMDXVisible 636ms 843ms 207ms 1.66 🔺24.6%

Greptile Summary

The pull request focuses on formatting fixes and linting improvements for the Storybook project.

  • code/addons/docs/docs/docspage.md: Improved import order for react-dom's render to maintain alphabetical order.
  • scripts/vite-ecosystem-ci/before-test.js: Updated to use Node.js built-in module imports (node:fs, node:path, node:url) and adjusted import order for execa and execaCommand.
  • No significant content changes, ensuring documentation consistency and script functionality remain intact.

@ndelangen ndelangen self-assigned this Aug 9, 2024
@ndelangen ndelangen added maintenance User-facing maintenance tasks ci:merged Run the CI jobs that normally run when merged. ci:normal labels Aug 9, 2024
Copy link

nx-cloud bot commented Aug 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fd5bd11. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@ndelangen ndelangen merged commit 81cdbba into next Aug 9, 2024
71 of 76 checks passed
@ndelangen ndelangen deleted the norbert/formatting-fixes-next branch August 9, 2024 18:46
@github-actions github-actions bot mentioned this pull request Aug 9, 2024
29 tasks
@shilman shilman added build Internal-facing build tooling & test updates and removed maintenance User-facing maintenance tasks labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:merged Run the CI jobs that normally run when merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants