Core: Enable RSC support when parameters.react is set to true #28865
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f747943. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
kasperpeulen
force-pushed
the
kasper/refactor-rsc-support
branch
from
b51278c
to
fa04511
Compare
kasperpeulen
force-pushed
the
kasper/refactor-rsc-support
branch
from
fa04511
to
14e18d9
Compare
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
11 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
There was a problem hiding this comment.
logic: Potential runtime error if React version is less than 18.3.
|
|
||
| export const decorators: Decorator[] = [ | ||
| (Story, context) => { | ||
| if (!context.parameters?.react?.rsc) return <Story />; |
There was a problem hiding this comment.
Can you change it to experimentalRsc? and update any documentation related to this, also potentially deprecate the main.js flag?
There was a problem hiding this comment.
Do we still want to call it experimental? @shilman
There was a problem hiding this comment.
Discussed with @shilman, we are not gonna remove the experimentalRsc flag, as in the future, we need to use it to for example register a webpack plugin that resolves the react-server condition for imports in server component files.
What I did
Enable RSC support when parameters.react is set to true
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
The pull request focuses on enabling React Server Components (RSC) support when
parameters.reactis set to true. Key changes include updates to type definitions, decorators, and ensuring compatibility with React versions 18.3 and above.code/core/src/preview-api/modules/store/csf/composeConfigs.ts: Updated to useNormalizedProjectAnnotationsfor RSC support.code/renderers/react/src/entry-preview-rsc.tsx: Simplified to setparameters.react.rscto true, removing previous decorator logic.code/renderers/react/src/entry-preview.tsx: Added decorator to check React version and wrap story inReact.Suspenseif RSC is enabled.code/renderers/react/src/portable-stories.tsx: UpdatedsetProjectAnnotationsto returnNormalizedProjectAnnotations<ReactRenderer>.code/frameworks/nextjs/src/portable-stories.ts: UpdatedsetProjectAnnotationsto returnNormalizedProjectAnnotations, aligning with other frameworks.