Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Reduce flake in BootstrapQueue test #28899

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Aug 15, 2024

Closes #28439

What I did

Add a long timout to waitFor in the BootstrapQueue.test.ts test.
(I know, not exactly rocket science, is it?)

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B 0.82 0%
initSize 169 MB 169 MB 0 B 1.76 0%
diffSize 92.6 MB 92.6 MB 0 B 1.76 0%
buildSize 7.46 MB 7.46 MB 0 B 1.73 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B 1.82 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.3 MB 2.3 MB 0 B 1.7 0%
buildSbPreviewSize 351 kB 351 kB 0 B -0.64 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.46 MB 4.46 MB 0 B 1.74 0%
buildPreviewSize 3 MB 3 MB 0 B 1.73 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 21.2s 22.9s 1.6s 1.08 7.3%
generateTime 21.4s 20.5s -915ms 0.2 -4.5%
initTime 17.3s 16.7s -667ms -0.35 -4%
buildTime 13.7s 12.3s -1s -367ms 0.15 -11%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.3s 7.4s 1.1s -0.48 15.3%
devManagerResponsive 4.2s 4.9s 723ms 0.04 14.6%
devManagerHeaderVisible 691ms 902ms 211ms 0.87 23.4%
devManagerIndexVisible 727ms 941ms 214ms 0.86 22.7%
devStoryVisibleUncached 1.1s 1s -118ms -1.57 🔰-11.7%
devStoryVisible 726ms 937ms 211ms 0.67 22.5%
devAutodocsVisible 625ms 735ms 110ms -0.15 15%
devMDXVisible 671ms 813ms 142ms 0.62 17.5%
buildManagerHeaderVisible 639ms 706ms 67ms -0.42 9.5%
buildManagerIndexVisible 646ms 780ms 134ms 0.46 17.2%
buildStoryVisible 675ms 777ms 102ms -0.1 13.1%
buildAutodocsVisible 567ms 843ms 276ms 1.99 🔺32.7%
buildMDXVisible 575ms 620ms 45ms -0.53 7.3%

Greptile Summary

This PR addresses a flaky test in the Angular framework's BootstrapQueue utility by increasing the timeout for the waitFor function.

  • Modified code/frameworks/angular/src/client/angular-beta/utils/BootstrapQueue.test.ts to add a 10-second timeout to the instantWaitFor function
  • Aims to reduce test failures due to timing issues in CI environments
  • Addresses issue CI Flake: BootstrapQueue.test.ts #28439 regarding CI flakes in the BootstrapQueue test
  • While effective, this approach may potentially mask underlying issues or slow down the test suite

@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Aug 15, 2024
@ndelangen ndelangen self-assigned this Aug 15, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Aug 15, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 47219d4. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@ndelangen ndelangen merged commit bf2e894 into next Aug 16, 2024
60 of 66 checks passed
@ndelangen ndelangen deleted the norbert/less-flaky-bootstrapqueue-test branch August 16, 2024 07:44
@github-actions github-actions bot mentioned this pull request Aug 16, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI Flake: BootstrapQueue.test.ts
1 participant