-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core: De-duplicate babel use in core #28972
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c8decc2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
How do you think this PR compares to yours here: #28571 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work @ndelangen -- this is a truly stupendous improvement!!!!!! ❤️ ❤️ ❤️
Approving on conditions that:
- You've tested the metafile generation changes
- You've tested the prettier changes
- You document how to test in the PR description
Also, in the future it would be better to split the babel & prettier changes into two separate PRs. But I'm fine with the one PR since it's already prepared.
What I did
I investigated the bundle meta file from esbuild for the core, and I noticed this:
Notice the exact same blocks 3 times in 3 entrypoints?
That's babel getting embedded 3 times.
Another way to look at it:
And I wondered, if this duplication can be dealt with by making an entry-point that exposes all these babel/transform related types and functions.
And the results are pretty good:
before:
after:
before:
after:
Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Before this change prettier would always be used to format files when we storybook them.
(save from controls, modifying
main.ts
etc.)Now that only happens if we can find
prettier
as a dep.(it's an optional peerDependency of the core)
No further testing instruction here, because there should be no user impact.
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal
,ci:merged
orci:daily
GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
bug
: Internal changes that fixes incorrect behavior.maintenance
: User-facing maintenance tasks.dependencies
: Upgrading (sometimes downgrading) dependencies.build
: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup
: Minor cleanup style change. Will not show up in release changelog.documentation
: Documentation only changes. Will not show up in release changelog.feature request
: Introducing a new feature.BREAKING CHANGE
: Changes that break compatibility in some way with current major version.other
: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/core
team here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>
Greptile Summary
This PR introduces changes to de-duplicate Babel usage in the Storybook core, aiming to reduce bundle size and improve performance.