Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next.js-Vite: Update next and vite-plugin-storybook-nextjs dependencies #28994

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Aug 28, 2024

Closes N/A

What I did

The Next.js peer dependency requirement was widened to also support v14.1.0 and up.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.4 MB 76.4 MB 0 B 0.42 0%
initSize 161 MB 161 MB 0 B -0.81 0%
diffSize 84.8 MB 84.8 MB 0 B -0.81 0%
buildSize 7.48 MB 7.48 MB 0 B 2.38 0%
buildSbAddonsSize 1.62 MB 1.62 MB 0 B 0.64 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.31 MB 2.31 MB 0 B 2.38 0%
buildSbPreviewSize 352 kB 352 kB 0 B 0.65 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.47 MB 4.47 MB 0 B 2.38 0%
buildPreviewSize 3.01 MB 3.01 MB 0 B 2.38 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 18.7s 23.6s 4.8s 1.07 20.7%
generateTime 22.2s 25.8s 3.5s 1.41 🔺13.8%
initTime 17.9s 22.1s 4.1s 4.01 🔺19%
buildTime 14.1s 10.7s -3s -414ms -1.72 🔰-31.8%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.6s 7.4s 804ms 0.15 10.8%
devManagerResponsive 4.2s 4.8s 649ms 0.25 13.3%
devManagerHeaderVisible 733ms 899ms 166ms 1.2 18.5%
devManagerIndexVisible 768ms 941ms 173ms 1.22 18.4%
devStoryVisibleUncached 1.3s 1.7s 416ms 1.55 🔺24.2%
devStoryVisible 767ms 935ms 168ms 1.09 18%
devAutodocsVisible 680ms 741ms 61ms 0.3 8.2%
devMDXVisible 652ms 848ms 196ms 1.38 🔺23.1%
buildManagerHeaderVisible 707ms 813ms 106ms 0.75 13%
buildManagerIndexVisible 709ms 820ms 111ms 0.64 13.5%
buildStoryVisible 760ms 859ms 99ms 0.58 11.5%
buildAutodocsVisible 630ms 829ms 199ms 2.45 🔺24%
buildMDXVisible 627ms 701ms 74ms 0.1 10.6%

Greptile Summary

This PR updates peer dependencies for the experimental Next.js-Vite framework in Storybook, widening compatibility and ensuring support for newer versions.

  • Updated Next.js peer dependency to support versions from 14.1.0 onwards in code/frameworks/experimental-nextjs-vite/package.json
  • Upgraded vite-plugin-storybook-nextjs peer dependency to version 1.0.8 or higher
  • Removed specific Next.js version (14.2.5) from devDependencies, allowing for more flexible development environments

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 🚀

The Next.js peer dependency requirement got widened to also support v14.1.0 and up.
@valentinpalkovic valentinpalkovic force-pushed the valentin/widen-nextjs-requirement branch from 072c2e5 to ebd3a98 Compare August 28, 2024 13:29
Copy link

nx-cloud bot commented Aug 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ebd3a98. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants