Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Rename vitest plugin entrypoint #29067

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Sep 6, 2024

Closes #

What I did

from @storybook/experimental-addon-test/vite-plugin to @storybook/experimental-addon-test/vitest-plugin

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.5 MB 76.8 MB 282 kB 21.44 0.4%
initSize 161 MB 161 MB 282 kB 7.52 0.2%
diffSize 84.7 MB 84.7 MB 0 B -0.23 0%
buildSize 7.52 MB 7.52 MB 0 B 4.36 0%
buildSbAddonsSize 1.62 MB 1.62 MB 0 B 4.34 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.34 MB 2.34 MB 0 B 4.36 0%
buildSbPreviewSize 352 kB 352 kB 0 B - 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.51 MB 4.51 MB 0 B 4.36 0%
buildPreviewSize 3.01 MB 3.01 MB 0 B 4.32 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 7.4s 13.5s 6s 0.06 44.7%
generateTime 21.1s 22s 901ms 0.14 4.1%
initTime 18.5s 18.3s -195ms 0.1 -1.1%
buildTime 11.8s 12s 268ms -0.11 2.2%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.7s 6.8s 83ms -0.2 1.2%
devManagerResponsive 4s 4.3s 320ms -0.19 7.3%
devManagerHeaderVisible 675ms 878ms 203ms 0.76 23.1%
devManagerIndexVisible 710ms 920ms 210ms 0.77 22.8%
devStoryVisibleUncached 1.1s 1.6s 468ms 0.92 28.7%
devStoryVisible 708ms 919ms 211ms 0.77 23%
devAutodocsVisible 661ms 725ms 64ms 0.01 8.8%
devMDXVisible 611ms 715ms 104ms 0.22 14.5%
buildManagerHeaderVisible 616ms 1s 397ms 2.89 🔺39.2%
buildManagerIndexVisible 616ms 1s 408ms 2.82 🔺39.8%
buildStoryVisible 653ms 1s 414ms 2.09 🔺38.8%
buildAutodocsVisible 568ms 972ms 404ms 2.83 🔺41.6%
buildMDXVisible 563ms 963ms 400ms 4.74 🔺41.5%

Greptile Summary

This PR renames the entrypoint for the Vitest plugin in the Storybook addon-test package from '@storybook/experimental-addon-test/vite-plugin' to '@storybook/experimental-addon-test/vitest-plugin'.

  • Updated import paths in multiple files to reflect the new 'vitest-plugin' naming
  • Renamed directory from 'plugin' to 'vitest-plugin' for better clarity
  • Modified package.json to use the new 'vitest-plugin' entrypoint
  • Updated sandbox configuration in scripts/tasks/sandbox-parts.ts
  • No functional changes introduced, purely a maintenance task for naming consistency

@yannbf yannbf added maintenance User-facing maintenance tasks addon: test ci:normal labels Sep 6, 2024
Copy link

nx-cloud bot commented Sep 6, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 236e51e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

13 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

@shilman shilman changed the title Maintenance: Rename vitest plugin entrypoint on addon test Test: Rename vitest plugin entrypoint Sep 6, 2024
@yannbf yannbf merged commit 01b9f91 into next Sep 6, 2024
56 checks passed
@yannbf yannbf deleted the yann/entrypoint-renaming branch September 6, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: test ci:normal maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants