Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rule for .md to angular webpack.config.prod.js #2924

Merged
merged 1 commit into from
Feb 6, 2018

Conversation

igor-dv
Copy link
Member

@igor-dv igor-dv commented Feb 6, 2018

Issue: #2883 (comment)

What I did

Added a missing rule for .md to the angular prod config

@igor-dv igor-dv added angular patch:yes Bugfix & documentation PR that need to be picked to main branch labels Feb 6, 2018
@igor-dv igor-dv self-assigned this Feb 6, 2018
@codecov
Copy link

codecov bot commented Feb 6, 2018

Codecov Report

Merging #2924 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2924   +/-   ##
=======================================
  Coverage   35.99%   35.99%           
=======================================
  Files         429      429           
  Lines        9503     9503           
  Branches      976      978    +2     
=======================================
  Hits         3421     3421           
- Misses       5423     5463   +40     
+ Partials      659      619   -40
Impacted Files Coverage Δ
...p/angular/src/server/config/webpack.config.prod.js 0% <ø> (ø) ⬆️
app/angular/src/server/config/webpack.config.js 0% <ø> (ø) ⬆️
app/polymer/src/server/config/babel.js 0% <0%> (-100%) ⬇️
app/polymer/src/server/babel_config.js 0% <0%> (-76.67%) ⬇️
app/polymer/src/server/utils.js 0% <0%> (-53.58%) ⬇️
app/react/src/demo/Welcome.js 64.7% <0%> (ø) ⬆️
addons/jest/src/components/Indicator.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/configs/init_panels.js 25% <0%> (ø) ⬆️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 20.96% <0%> (ø) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fd74f5...c8f3e6b. Read the comment docs.

@Hypnosphi Hypnosphi merged commit e157ffa into master Feb 6, 2018
@Hypnosphi Hypnosphi deleted the md-rules-for-angular-prod branch February 6, 2018 14:16
@Hypnosphi Hypnosphi added the bug label Feb 6, 2018
shilman pushed a commit that referenced this pull request Feb 11, 2018
Add rule for .md to angular webpack.config.prod.js
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants