ESM: CLI ESM-mode runtime #29317
Closed
ESM: CLI ESM-mode runtime #29317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 5 comment(s)
Edit PR Review Bot Settings | Greptile
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d7feafb. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
ndelangen
commented
Oct 10, 2024
| @@ -61,7 +60,7 @@ export const start: ViteBuilder['start'] = async ({ | |||
| }) => { | |||
| server = await createViteServer(options as Options, devServer); | |||
|
|
|||
| const previewResolvedDir = join(corePath, 'dist/preview'); | |||
| const previewResolvedDir = join((await import('storybook/core-path')).corePath, 'dist/preview'); | |||
There was a problem hiding this comment.
This could be reverted if the builder when loaded had it's ESM dist loaded instead of it's CJS.
This is to ensure 'storybook/core-path' is resolved to ESM.
ndelangen
commented
Oct 10, 2024
Comment on lines
-26
to
+29
| require('../dist/bin/index.cjs'); | ||
| import('../dist/bin/index.js').catch((error) => { | ||
| console.error(error); | ||
| process.exit(1); | ||
| }); |
There was a problem hiding this comment.
By loading the dist this way, the ESM file is picked/loaded.
ndelangen
commented
Oct 10, 2024
Comment on lines
30
to
+31
| "types": "./dist/index.d.ts", | ||
| "node": "./dist/index.cjs", | ||
| "import": "./dist/index.js", | ||
| "require": "./dist/index.cjs" | ||
| "import": "./dist/index.js" |
There was a problem hiding this comment.
The CJS files are no longer generated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I made a step towards ESM-only.
storybook/core-path, it was faux-ESMstorybook/core-path.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
This pull request transitions the Storybook CLI to an ESM-only runtime, modifying key files to support ES modules and asynchronous imports.
code/lib/cli/bin/index.cjsto use asynchronousimport()instead ofrequire()code/lib/cli/package.jsonto specify 'esm' as the only format under bundler configurationcode/lib/cli/src/proxy.tsto use dynamicimport()for '@storybook/core/cli/bin'index.cjsandproxy.ts