Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies: Upgrade VTA to v3.2.0 to resolve peerDep conflict #29461

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

ghengeveld
Copy link
Member

@ghengeveld ghengeveld commented Oct 28, 2024

Updated the VTA to v3.2.0 which specifies "storybook": "*" in its peerDependencies. This should fix compatibility with Storybook 8.4.0-alpha.1 and other prerelease versions.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 77.6 MB 77.6 MB 0 B 0.63 0%
initSize 143 MB 143 MB 0 B -1.72 0%
diffSize 65.1 MB 65.1 MB 0 B -1.72 0%
buildSize 6.87 MB 6.87 MB 0 B -0.22 0%
buildSbAddonsSize 1.51 MB 1.51 MB 0 B -0.54 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 1.9 MB 1.9 MB 0 B 2 0%
buildSbPreviewSize 271 kB 271 kB 0 B -0.33 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 3.88 MB 3.88 MB 0 B -0.22 0%
buildPreviewSize 3 MB 3 MB 0 B -0.58 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 22.8s 19.8s -3s -44ms 0.86 -15.4%
generateTime 20.4s 26.7s 6.2s 3.09 🔺23.4%
initTime 14s 18.4s 4.4s 3.33 🔺24.3%
buildTime 9.8s 10.1s 305ms 0.65 3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 6.5s 5.9s -590ms -1.07 -9.8%
devManagerResponsive 4.1s 3.8s -338ms -1.12 -8.8%
devManagerHeaderVisible 601ms 543ms -58ms -0.98 -10.7%
devManagerIndexVisible 672ms 577ms -95ms -1.14 -16.5%
devStoryVisibleUncached 1.2s 1.1s -117ms -0.32 -10.6%
devStoryVisible 669ms 576ms -93ms -0.99 -16.1%
devAutodocsVisible 605ms 579ms -26ms -0.28 -4.5%
devMDXVisible 628ms 557ms -71ms -0.43 -12.7%
buildManagerHeaderVisible 678ms 633ms -45ms -0.13 -7.1%
buildManagerIndexVisible 690ms 668ms -22ms 0.03 -3.3%
buildStoryVisible 676ms 632ms -44ms -0.11 -7%
buildAutodocsVisible 545ms 487ms -58ms -0.8 -11.9%
buildMDXVisible 496ms 482ms -14ms -0.62 -2.9%

Greptile Summary

Updates the @chromatic-com/storybook dependency from v3.1.0 to v3.2.0 to resolve peer dependency conflicts with Storybook 8.4.0-alpha.1 prerelease versions.

  • Updated @chromatic-com/storybook to ^3.2.0 in code/package.json to fix compatibility with Storybook prerelease versions
  • Package update is minimal and focused on resolving peer dependency version constraints

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Oct 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 61b821c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@kasperpeulen kasperpeulen merged commit a9bbf9b into next Oct 30, 2024
59 checks passed
@kasperpeulen kasperpeulen deleted the upgrade-vta-3.2.0 branch October 30, 2024 09:25
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants