Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix Solid init by installing @storybook/test #29514

Merged
merged 1 commit into from
Nov 2, 2024

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 2, 2024

Closes N/A

What I did

We recently released https://github.com/storybookjs/solidjs/releases/tag/v1.0.0-beta.3 that updates the CLI templates to use @storybook/test instead of @storybook/testing-library. This storybook init in a Solid project.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

If we were to release a canary, install it in a fresh Solid project. I've tested by hand already & it's a simple enough change.

At some point we should get the Solid sandboxes back into shape!

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Updates the Solid.js project initialization in Storybook CLI to use @storybook/test instead of @storybook/testing-library, aligning with the recent storybook-solidjs@1.0.0-beta.3 release.

  • Modified code/lib/create-storybook/src/generators/baseGenerator.ts to use @storybook/test for Solid.js projects
  • Kept @storybook/testing-library for Qwik projects only
  • Change requires manual testing with a fresh Solid project installation

@shilman shilman added bug cli patch:yes Bugfix & documentation PR that need to be picked to main branch solid ci:normal labels Nov 2, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Nov 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit a10154e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

@JonahPlusPlus JonahPlusPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit d130f0c into next Nov 2, 2024
67 of 73 checks passed
@shilman shilman deleted the shilman/fix-solid-init branch November 2, 2024 02:36
shilman added a commit that referenced this pull request Nov 5, 2024
CLI: Fix Solid init by installing `@storybook/test`
(cherry picked from commit d130f0c)
@github-actions github-actions bot added the patch:done Patch/release PRs already cherry-picked to main/release branch label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci:normal cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch solid
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants