Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TestAddon: Refactor UI & add config options #29662
TestAddon: Refactor UI & add config options #29662
Changes from 25 commits
d849ed7
917bb30
e47e23a
4e01e33
3196ee6
ac091c1
e9aa7fb
c889cfb
fa74d64
7a53842
b66b5fe
34b2a53
b8e0e2e
6938f52
f62c975
29f1b77
f603ffb
4956363
255e11f
942e321
2e4075f
27279ec
adb4e15
8ebbba4
e03be02
3f34f9d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: numTotalTests could be undefined here, which would show 'Testing... 5/undefined'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: Setting description to empty string when failed without error message could lead to confusing UI state. Consider showing a default failure message instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Fragment wrapper is unnecessary since LinkComponent is the only child
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
logic: delta calculation will be negative for future dates, but Math.abs is only used later - could cause incorrect time displays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: initial state should be typed as useState<string | null>(null)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Avoid using 'any' type for managerContext. Consider creating a proper type definition based on ManagerContext requirements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
style: Add error handling in case Edit button is not found