Release: Prerelease 8.5.0-alpha.11 #29700
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…use the story index to count the total number of tests and only run tests known by Storybook
…ing tests for Vitest
…bookjs/storybook into determine-total-test-count
…lar-sandboxes-ci Revert "Build: Add workaround resolution for Angular sandboxes"
Core + Addon Test: Refactor test API and fix total test count
github-actions
bot
requested review from
kylegach and
jonniebigodes
as code owners
github-actions
bot
added
the
release
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
25 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
| const index = (await Promise.race([ | ||
| fetch(indexUrl).then((res) => res.json()), | ||
| new Promise((_, reject) => setTimeout(reject, 3000, new Error('Request took too long'))), | ||
| ])) as StoryIndex; |
There was a problem hiding this comment.
style: Consider increasing timeout from 3000ms for slower networks/larger story indexes
| __VITEST_INCLUDE_TAGS__: finalOptions.tags.include.join(','), | ||
| __VITEST_EXCLUDE_TAGS__: finalOptions.tags.exclude.join(','), | ||
| __VITEST_SKIP_TAGS__: finalOptions.tags.skip.join(','), |
There was a problem hiding this comment.
style: Environment variables should be prefixed with STORYBOOK_ to avoid potential conflicts with other tools
| '@testing-library/dom': '^9.3.4', | ||
| '@testing-library/jest-dom': '^6.5.0', | ||
| '@testing-library/user-event': '^14.5.2', |
There was a problem hiding this comment.
style: Testing library dependencies use caret ranges while other deps use exact versions - should be consistent
| await runTestsButton.click(); | ||
|
|
||
| await expect(runTestsButton).toBeDisabled(); | ||
| await expect(watchModeButton).toBeDisabled(); |
There was a problem hiding this comment.
logic: The removed expectation for disabled run button suggests tests can now be triggered while another test is running. Verify this is intentional and won't cause race conditions.
This is an automated pull request that bumps the version from
8.5.0-alpha.10to8.5.0-alpha.11.Once this pull request is merged, it will trigger a new release of version
8.5.0-alpha.11.If you're not a core maintainer with permissions to release you can ignore this pull request.
To do
Before merging the PR, there are a few QA steps to go through:
And for each change below:
This is a list of all the PRs merged and commits pushed directly to
next, that will be part of this release:If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.
Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.
When everything above is done:
Generated changelog
8.5.0-alpha.11
Greptile Summary
Here's my summary of the key changes in this pull request:
Refactored test API and improved test execution in Storybook, focusing on simplifying the interface and improving accuracy.
TESTING_MODULE_RUN_REQUESTevent, removing separate "run all" eventindexUrland optionalstoryIdsparametersThe changes appear well-tested and maintain backward compatibility while significantly improving the testing infrastructure. The version bump from 8.5.0-alpha.10 to 8.5.0-alpha.11 is appropriate for these changes.