Release: Prerelease 8.5.0-beta.1 #30079

github-actions · 2024-12-16T14:53:39Z

This is an automated pull request that bumps the version from 8.5.0-beta.0 to 8.5.0-beta.1.
Once this pull request is merged, it will trigger a new release of version 8.5.0-beta.1.
If you're not a core maintainer with permissions to release you can ignore this pull request.

To do

Before merging the PR, there are a few QA steps to go through:

Add the "freeze" label to this PR, to ensure it doesn't get automatically forced pushed by new changes.
Add the "ci:daily" label to this PR, to trigger the full test suite to run on this PR.

And for each change below:

Ensure the change is appropriate for the version bump. E.g. patch release should only contain patches, not new or de-stabilizing features. If a change is not appropriate, revert the PR.
Ensure the PR is labeled correctly with one of: "BREAKING CHANGE", "feature request", "bug", "maintenance", "dependencies", "documentation", "build", "unknown".
Ensure the PR title is correct, and follows the format "[Area]: [Summary]", e.g. "React: Fix hooks in CSF3 render functions". If it is not correct, change the title in the PR.
- Areas include: React, Vue, Core, Docs, Controls, etc.
- First word of summary indicates the type: “Add”, “Fix”, “Upgrade”, etc.
- The entire title should fit on a line

This is a list of all the PRs merged and commits pushed directly to next, that will be part of this release:

🐛 Bug: Addon Test: Fix printing null% for coverage #30061
🔧 Maintenance: Addon A11y: Remove warnings API #30049
🐛 Bug: Addon A11y: Show errors of axe properly #30050
🔧 Maintenance: Telemetry: Add metadata distinguishing "apps" from "design systems" #30070
🐛 Bug: Addon A11y: Add conditional rendering for a11y violation number in Testing Module #30073

If you've made any changes doing the above QA (change PR titles, revert PRs), manually trigger a re-generation of this PR with this workflow and wait for it to finish. It will wipe your progress in this to do, which is expected.

Feel free to manually commit any changes necessary to this branch after you've done the last re-generation, following the Make Manual Changes section in the docs, especially if you're making changes to the changelog.

When everything above is done:

Merge this PR
Follow the run of the publish action

Generated changelog

8.5.0-beta.1

Addon A11y: Add conditional rendering for a11y violation number in Testing Module - #30073, thanks @valentinpalkovic!
Addon A11y: Remove warnings API - #30049, thanks @kasperpeulen!
Addon A11y: Show errors of axe properly - #30050, thanks @kasperpeulen!
Addon Test: Fix printing null% for coverage - #30061, thanks @ghengeveld!
Telemetry: Add metadata distinguishing "apps" from "design systems" - #30070, thanks @tmeasday!

…s-api # Conflicts: # docs/writing-tests/accessibility-testing.mdx

… kasper/remove-warnings-api

…-from-status Addon A11y: Add conditional rendering for a11y violation number in Testing Module

Telemetry: Add metadata distinguishing "apps" from "design systems"

Addon A11y: Show errors of axe properly

Addon A11y: Remove warnings API

Addon Test: Fix printing null% for coverage

greptile-apps

_{29 file(s) reviewed, 13 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

greptile-apps · 2024-12-16T14:54:38Z

code/addons/a11y/src/components/A11YPanel.tsx

+              {typeof error === 'string'
+                ? error
+                : error instanceof Error
+                  ? error.toString()
+                  : JSON.stringify(error)}
            </>


style: Consider using a dedicated error formatting utility function to handle error types consistently across the codebase

greptile-apps · 2024-12-16T14:54:41Z

CHANGELOG.prerelease.md

+## 8.5.0-beta.1
+
+- Addon A11y: Add conditional rendering for a11y violation number in Testing Module - [#30073](https://github.com/storybookjs/storybook/pull/30073), thanks @valentinpalkovic!
+- Addon A11y: Remove warnings API - [#30049](https://github.com/storybookjs/storybook/pull/30049), thanks @kasperpeulen!


logic: Breaking change: Removes warnings API and warning levels configuration from a11y addon

greptile-apps · 2024-12-16T14:55:20Z

code/addons/a11y/src/preview.tsx

      if (result) {
        const hasViolations = (result?.violations.length ?? 0) > 0;

-        const hasErrors = result?.violations.some(
-          (violation) => !warnings.includes(violation.impact!)
-        );
-
        reporting.addReport({
          type: 'a11y',
          version: 1,
          result: result,
-          status: hasErrors ? 'failed' : hasViolations ? 'warning' : 'passed',
+          status: hasViolations ? 'failed' : 'passed',
        });


logic: Breaking change: Simplified status reporting from three states (passed/warning/failed) to two states (passed/failed). This needs to be documented in MIGRATION.md

greptile-apps · 2024-12-16T14:56:13Z

code/core/src/telemetry/exec-command-count-lines.test.ts

+  const promiseLike: ExecaStreamer = new Promise<void>((aResolver, aRejecter) => {
+    resolver = aResolver;
+  }) as any;


style: The Promise resolver is created but the rejector parameter is unused. Consider removing the unused parameter or handling rejection cases.

greptile-apps · 2024-12-16T14:56:23Z

code/core/src/telemetry/exec-command-count-lines.ts

+  command: string,
+  options?: Parameters<typeof execaCommand>[1]
+) {
+  const process = execaCommand(command, { shell: true, buffer: false, ...options });


logic: setting shell:true can be a security risk if command includes user input

greptile-apps · 2024-12-16T14:56:54Z

code/core/src/telemetry/get-application-file-count.ts

+  } catch {
+    return undefined;
+  }


style: catch block silently returns undefined without logging the error - consider adding error logging for debugging

greptile-apps · 2024-12-16T14:57:08Z

code/core/src/telemetry/get-has-router-package.ts

@@ -0,0 +1,37 @@
+import type { PackageJson } from '../types';
+
+const routerPackages = new Set([


style: Consider adding @ionic/angular-router and @ionic/vue-router to support Ionic framework routing packages

greptile-apps · 2024-12-16T14:57:33Z

code/core/src/telemetry/get-portable-stories-usage.ts

+    const command = `git grep -l composeStor` + (path ? ` -- ${path}` : '');
+    return await execCommandCountLines(command);


logic: The git grep command is missing the full word boundary - should be composeStories to avoid partial matches

greptile-apps · 2024-12-16T14:57:34Z

code/core/src/telemetry/get-portable-stories-usage.ts

+    // exit code 1 if no matches are found
+    return err.exitCode === 1 ? 0 : undefined;
+  }


logic: Returning undefined for non-exit-code-1 errors loses important error information that could help debug issues

greptile-apps · 2024-12-16T14:58:39Z

code/sandbox/experimental-nextjs-vite-default-ts/project.json

+  "targets": {
+    "sandbox": {},
+    "sb:dev": {},
+    "sb:build": {}
+  },


style: The empty target configurations could use more explicit settings to ensure proper sandbox, dev and build behavior

nx-cloud · 2024-12-16T16:20:34Z

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ba9d402. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

storybook-pr-benchmarking · 2024-12-16T16:28:46Z

Package Benchmarks

^{Commit: ba9d402, ran on 16 December 2024 at 16:28:44 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/vue3-vite`

	Before	After	Difference
Dependency count	111	107	🎉 -4 🎉
Self size	16 KB	15 KB	🎉 -8 B 🎉
Dependency size	45.54 MB	45.46 MB	🎉 -78 KB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/preset-vue3-webpack`

	Before	After	Difference
Dependency count	378	374	🎉 -4 🎉
Self size	9 KB	9 KB	🎉 -6 B 🎉
Dependency size	50.58 MB	50.51 MB	🎉 -78 KB 🎉
Bundle Size Analyzer	Link	Link

kasperpeulen and others added 28 commits December 12, 2024 16:09

Remove warnings API

80ff572

Show errors of axe properly

bc8181d

Fix status to be failed

25a3a33

Merge branch 'next' into kasper/a11y-errors

99f8bbc

Merge remote-tracking branch 'origin/next' into kasper/remove-warning…

a93b347

…s-api # Conflicts: # docs/writing-tests/accessibility-testing.mdx

Merge branch 'next' into kasper/remove-warnings-api

1ae4f48

Fix printing null%

f0f4e48

Record metadata.hasRouterPackage

5484c5e

Add tool to count lines in a command

766645f

Added metadata.applicationFileCount

11e0729

We need to put a path seperator or git complains

0b45cb3

Experiment: Highlight VTA on first load if it's installed

7a3e991

Merge branch 'next' into kasper/a11y-errors

21de1e2

Merge branch 'next' into kasper/remove-warnings-api

d2a2abe

Fix some greptile things

f94f7d9

Merge branch 'next' into fix-null-percent

ea3be92

Add conditional rendering for a11yNotPassedAmount based on story entry

d09ea61

E2E Tests: Fix failing test when Controls is not the default tab

2307f9f

Merge branch 'next' into kasper/a11y-errors

46d8d0a

UI: Fix bug where unknown addon panel selection defaults to first tab

2a5a855

Merge branch 'next' into fix-null-percent

312047f

Adjust sandbox parts

e8d9601

Merge remote-tracking branch 'origin/kasper/remove-warnings-api' into…

9c86875

… kasper/remove-warnings-api

Merge pull request #30073 from storybookjs/valentin/remove-test-count…

faaf253

…-from-status Addon A11y: Add conditional rendering for a11y violation number in Testing Module

Merge pull request #30070 from storybookjs/tom/metadata-tweaks

c3e1496

Telemetry: Add metadata distinguishing "apps" from "design systems"

Merge pull request #30050 from storybookjs/kasper/a11y-errors

29f4573

Addon A11y: Show errors of axe properly

Merge pull request #30049 from storybookjs/kasper/remove-warnings-api

9f8e47c

Addon A11y: Remove warnings API

Merge branch 'next-release' into next

9cf63df

github-actions bot requested review from kylegach and jonniebigodes as code owners December 16, 2024 14:53

github-actions bot added the release For PRs that trigger new releases. Automated label Dec 16, 2024

Merge pull request #30061 from storybookjs/fix-null-percent

9b1a93b

Addon Test: Fix printing null% for coverage

greptile-apps bot reviewed Dec 16, 2024

View reviewed changes

Write changelog for 8.5.0-beta.1 [skip ci]

ba9d402

storybook-bot force-pushed the version-non-patch-from-8.5.0-beta.0 branch from 1188d0f to ba9d402 Compare December 16, 2024 15:03

vanessayuenn added ci:daily Run the CI jobs that normally run in the daily job. freeze Freeze the Release PR with this label labels Dec 16, 2024

vanessayuenn merged commit 862c699 into next-release Dec 16, 2024
99 of 110 checks passed

vanessayuenn deleted the version-non-patch-from-8.5.0-beta.0 branch December 16, 2024 16:59

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release: Prerelease 8.5.0-beta.1 #30079

Release: Prerelease 8.5.0-beta.1 #30079

github-actions bot commented Dec 16, 2024 •

edited

Loading

greptile-apps bot left a comment

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

greptile-apps bot Dec 16, 2024

nx-cloud bot commented Dec 16, 2024 •

edited

Loading

storybook-pr-benchmarking bot commented Dec 16, 2024

		@@ -0,0 +1,37 @@
		import type { PackageJson } from '../types';

		const routerPackages = new Set([

		const command = `git grep -l composeStor` + (path ? ` -- ${path}` : '');
		return await execCommandCountLines(command);

Release: Prerelease 8.5.0-beta.1 #30079

Release: Prerelease 8.5.0-beta.1 #30079

Conversation

github-actions bot commented Dec 16, 2024 • edited Loading

To do

Generated changelog

8.5.0-beta.1

greptile-apps bot left a comment

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

greptile-apps bot Dec 16, 2024

Choose a reason for hiding this comment

nx-cloud bot commented Dec 16, 2024 • edited Loading

☁️ Nx Cloud Report

storybook-pr-benchmarking bot commented Dec 16, 2024

Package Benchmarks

@storybook/vue3-vite

@storybook/preset-vue3-webpack

github-actions bot commented Dec 16, 2024 •

edited

Loading

nx-cloud bot commented Dec 16, 2024 •

edited

Loading

`@storybook/vue3-vite`

`@storybook/preset-vue3-webpack`