Build: Replace last 'src', not 1st 'src' in entry file paths #30404
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
5 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 5705ef1.
☁️ Nx Cloud last updated this comment at |
boylec
changed the title
boylec
changed the title
There was a problem hiding this comment.
LGTM
5 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
shilman
changed the title
There was a problem hiding this comment.
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Package BenchmarksCommit: The following packages have significant changes to their size or dependencies:
|
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 17 | 17 | 0 |
| Self size | 2.26 MB | 2.20 MB | 🎉 -61 KB 🎉 |
| Dependency size | 7.92 MB | 7.92 MB | 0 B |
| Bundle Size Analyzer | Link | Link |
@storybook/addon-essentials
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 36 | 36 | 0 |
| Self size | 12 KB | 12 KB | 0 B |
| Dependency size | 13.93 MB | 13.87 MB | 🎉 -61 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/preact-vite
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 13 | 13 | 0 |
| Self size | 5 KB | 6 KB | 🚨 +743 B 🚨 |
| Dependency size | 1.31 MB | 1.31 MB | 🎉 -1 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
@storybook/cli
| Before | After | Difference | |
|---|---|---|---|
| Dependency count | 388 | 388 | 0 |
| Self size | 503 KB | 503 KB | 🚨 +310 B 🚨 |
| Dependency size | 75.37 MB | 75.35 MB | 🎉 -13 KB 🎉 |
| Bundle Size Analyzer | Link | Link |
|
@valentinpalkovic just a heads up: I resolved your comment |
Closes #30403
What I did
Updated core build scripts to replace last occurrence of 'src' with 'dist' instead of first occurrence.
Otherwise, if someone clones the storybook repo (for the purposes of contributing) in a path like
/Users/theperson/src/storybookthen the core build/prep scripts fail due to some pathing issues on the esbuild compile steps.Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
Documentation
MIGRATION.MD
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.🦋 Canary release
@storybookjs/core can we do a canary release of this?
This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the
@storybookjs/coreteam here.core team members can create a canary release here or locally with
gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>Greptile Summary
Fixed critical path resolution issue in Storybook's core build process by modifying how 'src' to 'dist' path transformations are handled to prevent build failures when Storybook is installed in paths containing 'src'.
replaceSrcWithDistutility inscripts/utils/paths.tsto replace only last occurrence of 'src'code/core/scripts/prep.tsto use new utility for correct path transformationsgenerateTypesMapperFiles.tsandgeneratePackageJsonFile.tsfor consistent handling/Users/person/src/storybook)💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!