Docs: Fix incorrect context usage in Svelte example #30560
Conversation
https://svelte.dev/docs/svelte/svelte-files In svelte 5, module scripts should be `<script module>` instead of the previous `<script context="module">` from svelte 4 and before.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
@Masstronaut, thank you for taking the time to put together this pull request and helping us improve the documentation by catching this small typo in the examples. We appreciate it. I've checked, and all is good on my end. I'll gladly merge this once the checklist clears.
Hope you have a great day.
Stay safe
jonniebigodes
changed the title
jonniebigodes
added
documentation
ci:docs
There was a problem hiding this comment.
LGTM
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
|
View your CI Pipeline Execution ↗ for commit 87f50e6.
☁️ Nx Cloud last updated this comment at |
https://svelte.dev/docs/svelte/svelte-files
In svelte 5, module scripts should be
<script module>instead of the previous<script context="module">from svelte 4 and before.What I did
Svelte module scripts are
<script module>not<script context>. I think it was just migrated incorrectly from<script context="module">Checklist for Contributors
Testing
The changes in this PR are covered in the following automated tests:
Manual testing
I don't believe manual testing is necessary for this change.
Documentation
This is a purely documentation update.
Checklist for Maintainers
When this PR is ready for testing, make sure to add
ci:normal,ci:mergedorci:dailyGH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found incode/lib/cli-storybook/src/sandbox-templates.tsMake sure this PR contains one of the labels below:
Available labels
bug: Internal changes that fixes incorrect behavior.maintenance: User-facing maintenance tasks.dependencies: Upgrading (sometimes downgrading) dependencies.build: Internal-facing build tooling & test updates. Will not show up in release changelog.cleanup: Minor cleanup style change. Will not show up in release changelog.documentation: Documentation only changes. Will not show up in release changelog.feature request: Introducing a new feature.BREAKING CHANGE: Changes that break compatibility in some way with current major version.other: Changes that don't fit in the above categories.Greptile Summary
Updates Svelte CSF story migration documentation to align with Svelte 5's module script syntax, replacing the outdated
<script context>with the new<script module>directive.<script context>to<script module>in/docs/_snippets/svelte-csf-story-migration.mdto match current Svelte 5 standards💡 (1/5) You can manually trigger the bot by mentioning @greptileai in a comment!