Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Disable benchmark scripts #30775

Merged
merged 2 commits into from
Mar 8, 2025
Merged

Conversation

kasperpeulen
Copy link
Contributor

@kasperpeulen kasperpeulen commented Mar 7, 2025

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

Greptile Summary

Disabled benchmark scripts in CircleCI configuration by commenting out the bench-sandboxes job across normal, merged, and daily workflows.

  • Commented out bench-sandboxes job execution in .circleci/config.yml with parallelism of 5
  • Added TODO comment indicating future re-enablement requirement
  • Removed benchmark dependency from workflow completion checks

@kasperpeulen kasperpeulen changed the title Disable benchmark scripts Build: Disable benchmark scripts Mar 7, 2025
@kasperpeulen kasperpeulen added build Internal-facing build tooling & test updates ci:normal labels Mar 7, 2025
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

nx-cloud bot commented Mar 7, 2025

View your CI Pipeline Execution ↗ for commit 4634b16.

Command Status Duration Result
nx run-many -t build --parallel=3 ✅ Succeeded 1m 56s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-08 13:12:22 UTC

@storybook-pr-benchmarking
Copy link

storybook-pr-benchmarking bot commented Mar 7, 2025

Package Benchmarks

Commit: 4634b16, ran on 8 March 2025 at 13:15:20 UTC

No significant changes detected, all good. 👏

@kasperpeulen kasperpeulen enabled auto-merge March 8, 2025 13:08
@kasperpeulen kasperpeulen disabled auto-merge March 8, 2025 15:39
@kasperpeulen kasperpeulen merged commit db97f68 into next Mar 8, 2025
51 of 55 checks passed
@kasperpeulen kasperpeulen deleted the kasper/disable-benchmarks branch March 8, 2025 15:39
@github-actions github-actions bot mentioned this pull request Mar 8, 2025
14 tasks
@shilman shilman added the patch:yes Bugfix & documentation PR that need to be picked to main branch label Mar 9, 2025
@github-actions github-actions bot mentioned this pull request Mar 10, 2025
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:normal patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants