-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addon-options: Make shortcuts in storybook optional #3237
Conversation
Should we remove shortcuts help button and popup when shortcuts are disabled? |
Yeah, that makes sense to disable it. Or we can add a text saying that |
Codecov Report
@@ Coverage Diff @@
## master #3237 +/- ##
==========================================
- Coverage 35.9% 35.86% -0.05%
==========================================
Files 440 440
Lines 9669 9682 +13
Branches 904 912 +8
==========================================
Hits 3472 3472
+ Misses 5626 5625 -1
- Partials 571 585 +14
Continue to review full report at Codecov.
|
Hey @Hypnosphi, Removed the shortcut help button when |
@@ -84,6 +97,16 @@ StoriesPanel.propTypes = { | |||
openShortcutsHelp: PropTypes.func, | |||
name: PropTypes.string, | |||
url: PropTypes.string, | |||
shortcutOptions: PropTypes.objectof( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: objectOf
But it's actually not needed here, it should be just shape
Issue: #3196
What I did
I've added an option for
enabling/disabling
keyboard shortcuts.How to test
One can try this feature by updating the storybook
config.js
as: