Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object proptype is shown in addon-info proptable #3255

Merged
merged 3 commits into from
Mar 21, 2018

Conversation

binomialstew
Copy link

What I did

Corrects this issue.

@Hypnosphi Hypnosphi added bug addon: info patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 21, 2018
@Hypnosphi
Copy link
Member

Live preview

@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #3255 into master will decrease coverage by 0.24%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3255      +/-   ##
==========================================
- Coverage   35.85%   35.61%   -0.25%     
==========================================
  Files         444      442       -2     
  Lines        9731     9777      +46     
  Branches      909      911       +2     
==========================================
- Hits         3489     3482       -7     
- Misses       5652     5716      +64     
+ Partials      590      579      -11
Impacted Files Coverage Δ
addons/info/src/components/types/PrettyPropType.js 85.71% <ø> (-0.29%) ⬇️
addons/knobs/src/components/types/Object.js 5.88% <0%> (-11.36%) ⬇️
addons/links/src/react/components/link.js 78.78% <0%> (ø) ⬆️
lib/ui/src/modules/shortcuts/actions/shortcuts.js 18.84% <0%> (ø) ⬆️
addons/storysource/src/loader/parsers/index.js 44.44% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/shortcuts_help.js 12.85% <0%> (ø) ⬆️
addons/knobs/src/components/types/Button.js 11.9% <0%> (ø) ⬆️
addons/actions/src/lib/types/infinity/index.js 80% <0%> (ø) ⬆️
addons/knobs/src/components/types/Array.js 34.14% <0%> (ø) ⬆️
app/angular/src/server/angular-cli_config.js 0% <0%> (ø) ⬆️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d104cd...6031eab. Read the comment docs.

@binomialstew
Copy link
Author

Please let me know if there's anything I can do for this

@Hypnosphi Hypnosphi merged commit 01ebb65 into storybookjs:master Mar 21, 2018
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 29, 2018
Hypnosphi added a commit that referenced this pull request Mar 29, 2018
Object proptype is shown in addon-info proptable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: info bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants