Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create CODEOWNERS from git history #3296

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Create CODEOWNERS from git history #3296

merged 1 commit into from
Mar 26, 2018

Conversation

danielduan
Copy link
Member

@danielduan danielduan commented Mar 26, 2018

Issue: #1425

It's been hard to find people who are knowledgeable about a specific portion of the codebase. This should at least point someone in the right direction.

Feel free to remove your name if you don't want to be the point person for a specific portion of the codebase.

What I did

created CODEOWNERS from git history

@danielduan danielduan added the maintenance User-facing maintenance tasks label Mar 26, 2018
@danielduan danielduan requested a review from a team March 26, 2018 21:07
@Hypnosphi Hypnosphi merged commit 72210c5 into master Mar 26, 2018
@Hypnosphi Hypnosphi deleted the codeowners branch March 26, 2018 21:19
@codecov
Copy link

codecov bot commented Mar 26, 2018

Codecov Report

Merging #3296 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3296   +/-   ##
=======================================
  Coverage   36.21%   36.21%           
=======================================
  Files         444      444           
  Lines        9736     9736           
  Branches      913      902   -11     
=======================================
  Hits         3526     3526           
- Misses       5603     5638   +35     
+ Partials      607      572   -35
Impacted Files Coverage Δ
app/react/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/info/src/components/types/PrettyPropType.js 85.71% <0%> (ø) ⬆️
lib/core/src/client/manager/provider.js 0% <0%> (ø) ⬆️
app/react-native/src/bin/storybook.js 0% <0%> (ø) ⬆️
addons/a11y/src/components/Tabs.js 0% <0%> (ø) ⬆️
addons/storysource/src/loader/generate-helpers.js 44.44% <0%> (ø) ⬆️
...ddons/actions/src/components/ActionLogger/style.js 0% <0%> (ø) ⬆️
lib/core/src/server/build-dev.js 0% <0%> (ø) ⬆️
addons/knobs/src/components/types/Button.js 11.9% <0%> (ø) ⬆️
addons/storysource/src/loader/inject-decorator.js 28% <0%> (ø) ⬆️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 143e510...57b1ff5. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants