Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: add error handling for latest_version helper #3297

Merged
merged 2 commits into from
Mar 27, 2018
Merged

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Mar 27, 2018

Issue: #3275 doesn't provide good messages for not yet published packages, see #3244 CI failure. Plus, it doesn't actually work with npm and uses spawnSync which makes job slower.

What I did

Added error handling, used async spawn

@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #3297 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3297      +/-   ##
==========================================
- Coverage   36.12%   36.09%   -0.03%     
==========================================
  Files         445      445              
  Lines        9775     9783       +8     
  Branches      918      907      -11     
==========================================
  Hits         3531     3531              
- Misses       5657     5709      +52     
+ Partials      587      543      -44
Impacted Files Coverage Δ
lib/cli/lib/latest_version.js 0% <0%> (ø) ⬆️
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/storyshots/src/rn/loader.js 53.33% <0%> (ø) ⬆️
addons/knobs/src/components/types/Array.js 34.14% <0%> (ø) ⬆️
.../ui/components/stories_panel/stories_tree/index.js 38.73% <0%> (ø) ⬆️
addons/storysource/src/loader/traverse-helpers.js 60.86% <0%> (ø) ⬆️
addons/info/src/components/types/OneOf.js 61.11% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/search_box.js 23.52% <0%> (ø) ⬆️
.../src/modules/ui/components/stories_panel/header.js 28.57% <0%> (ø) ⬆️
lib/ui/src/modules/api/actions/api.js 51.85% <0%> (ø) ⬆️
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2994fc1...502a9e4. Read the comment docs.

@Hypnosphi Hypnosphi merged commit bdbb171 into master Mar 27, 2018
@Hypnosphi Hypnosphi deleted the cli-helpful-errors branch March 27, 2018 11:37
@Hypnosphi Hypnosphi added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 29, 2018
Hypnosphi added a commit that referenced this pull request Mar 29, 2018
CLI: add error handling for latest_version helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug cli patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants