-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: add error handling for latest_version helper #3297
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hypnosphi
requested review from
danielduan,
ndelangen,
shilman and
stijnkoopal
as code owners
March 27, 2018 00:39
Merged
danielduan
approved these changes
Mar 27, 2018
Codecov Report
@@ Coverage Diff @@
## master #3297 +/- ##
==========================================
- Coverage 36.12% 36.09% -0.03%
==========================================
Files 445 445
Lines 9775 9783 +8
Branches 918 907 -11
==========================================
Hits 3531 3531
- Misses 5657 5709 +52
+ Partials 587 543 -44
Continue to review full report at Codecov.
|
Hypnosphi
added
patch:yes
Bugfix & documentation PR that need to be picked to main branch
patch:done
Patch/release PRs already cherry-picked to main/release branch
labels
Mar 29, 2018
Hypnosphi
added a commit
that referenced
this pull request
Mar 29, 2018
CLI: add error handling for latest_version helper
This was referenced Jan 15, 2021
This was referenced May 31, 2021
Open
Open
1 task
1 task
Closed
1 task
Open
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
cli
patch:done
Patch/release PRs already cherry-picked to main/release branch
patch:yes
Bugfix & documentation PR that need to be picked to main branch
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #3275 doesn't provide good messages for not yet published packages, see #3244 CI failure. Plus, it doesn't actually work with npm and uses spawnSync which makes job slower.
What I did
Added error handling, used async spawn