Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaks for range labels #3340

Merged
merged 2 commits into from
Apr 2, 2018
Merged

Tweaks for range labels #3340

merged 2 commits into from
Apr 2, 2018

Conversation

Primigenus
Copy link
Contributor

Aligns the font size with the knob label and ensures the range label doesn't wrap.

How to test

Add addon-knobs and a number range knob and observe result.

Aligns the font size with the knob label and ensures the range label doesn't wrap.
@Hypnosphi Hypnosphi added addon: knobs cleanup Minor cleanup style change that won't show up in release changelog labels Apr 2, 2018
@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #3340 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3340   +/-   ##
=======================================
  Coverage   35.63%   35.63%           
=======================================
  Files         472      472           
  Lines       10122    10122           
  Branches      945      970   +25     
=======================================
  Hits         3607     3607           
+ Misses       5925     5900   -25     
- Partials      590      615   +25
Impacted Files Coverage Δ
addons/knobs/src/components/types/Number.js 7.46% <0%> (ø) ⬆️
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
addons/viewport/src/preview/components/Viewport.js 95.74% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/index.js 27.15% <0%> (ø) ⬆️
addons/knobs/src/mithril/WrapStory.js 0% <0%> (ø) ⬆️
lib/ui/src/modules/ui/containers/shortcuts_help.js 25% <0%> (ø) ⬆️
...es__/update-addon-info/update-addon-info.output.js 0% <0%> (ø) ⬆️
addons/jest/src/components/Result.js 0% <0%> (ø) ⬆️
...ns/viewport/src/manager/components/viewportInfo.js 33.33% <0%> (ø) ⬆️
addons/actions/src/lib/types/infinity/index.js 80% <0%> (ø) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f2304c...244a0d5. Read the comment docs.

@Hypnosphi Hypnosphi merged commit d54fb75 into storybookjs:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: knobs cleanup Minor cleanup style change that won't show up in release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants