-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a configuration option to limit the number of actions logged #3447
Provide a configuration option to limit the number of actions logged #3447
Conversation
A default limit could probably be added to configureActions, not sure what the default value should be though. I've added @Hypnosphi as reviewer, does the PR also need to include an example in the |
I think we should set a sensible default for all users while we're making this change. This seems like an obvious optimization we can make on behalf of all users. does 50 sound like a good number? |
Yeah, that wouldn't hurt
Makes sense to me |
Sure, I'll make those additions. |
Codecov Report
@@ Coverage Diff @@
## master #3447 +/- ##
==========================================
+ Coverage 37.42% 92.5% +55.07%
==========================================
Files 455 6 -449
Lines 10296 40 -10256
Branches 911 2 -909
==========================================
- Hits 3853 37 -3816
+ Misses 5915 2 -5913
+ Partials 528 1 -527 Continue to review full report at Codecov.
|
@jcharry can you fix the failing test here?
|
@danielduan done! |
Please add a usage example to |
@Hypnosphi Okay, added an example. |
d2c8c01
to
e5766e4
Compare
e5766e4
to
578c575
Compare
Rebased and should be good to go now. |
Issue: The actions logger panel accumulates actions for a story endlessly. After a while, this creates quite a bit of lag. You can hit the clear button to clear out the logger and performance improves again, but it'd be nice to have a configuration hook to set a hard upper bound on the number of actions that should be logged.
What I did
Added a configuration option called
limit
to theconfigureActions
call.