storybookjs · tmeasday · Jan 8, 2019 · Oct 19, 2018 · Oct 20, 2018 · Oct 22, 2018
diff --git a/.babelrc.js b/.babelrc.js
@@ -5,11 +5,13 @@ module.exports = {
     '@babel/preset-flow',
   ],
   plugins: [
-    'babel-plugin-emotion',
-    'babel-plugin-macros',
-    '@babel/plugin-proposal-class-properties',
-    '@babel/plugin-proposal-object-rest-spread',
+    ['@babel/plugin-proposal-object-rest-spread', { loose: true, useBuiltIns: true }],
     '@babel/plugin-proposal-export-default-from',
+    '@babel/plugin-syntax-dynamic-import',
+    ['@babel/plugin-proposal-class-properties', { loose: true }],
+    'babel-plugin-add-react-displayname',
+    'babel-plugin-macros',
+    ['emotion', { sourceMap: true, autoLabel: true }],
   ],
   env: {
     test: {

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1,7 +1,6 @@
 const error = 2;
 const warn = 1;
 const ignore = 0;
-
 module.exports = {
   root: true,
   extends: [
@@ -11,37 +10,18 @@ module.exports = {
     'prettier',
     'prettier/react',
   ],
-  plugins: ['prettier', 'jest', 'import', 'react', 'jsx-a11y', 'json'],
+  plugins: ['prettier', 'jest', 'import', 'react', 'jsx-a11y', 'json', 'html'],
   parser: 'babel-eslint',
-  parserOptions: {
-    ecmaVersion: 8,
-    sourceType: 'module',
-  },
-  env: {
-    es6: true,
-    node: true,
-    'jest/globals': true,
-  },
+  parserOptions: { ecmaVersion: 8, sourceType: 'module' },
+  env: { es6: true, node: true, 'jest/globals': true },
   settings: {
     'import/core-modules': ['enzyme'],
     'import/ignore': ['node_modules\\/(?!@storybook)'],
-    'import/resolver': {
-      node: {
-        extensions: ['.js', '.ts'],
-      },
-    },
+    'import/resolver': { node: { extensions: ['.js', '.ts'] } },
+    'html/html-extensions': ['.html'],
   },
   rules: {
-    'prettier/prettier': [
-      warn,
-      {
-        printWidth: 100,
-        tabWidth: 2,
-        bracketSpacing: true,
-        trailingComma: 'es5',
-        singleQuote: true,
-      },
-    ],
+    'prettier/prettier': [warn],
     'no-debugger': process.env.NODE_ENV === 'production' ? error : ignore,
     'class-methods-use-this': ignore,
     'import/extensions': [
@@ -101,46 +81,30 @@ module.exports = {
       },
     ],
     'react/no-unescaped-entities': ignore,
-    'jsx-a11y/label-has-for': [
-      error,
-      {
-        required: {
-          some: ['nesting', 'id'],
-        },
-      },
-    ],
+    'jsx-a11y/label-has-for': [error, { required: { some: ['nesting', 'id'] } }],
     'jsx-a11y/anchor-is-valid': [
       error,
       {
-        components: ['RoutedLink', 'MenuLink', 'LinkTo', 'Link'],
+        components: ['RoutedLink', 'LinkTo', 'Link'],
         specialLink: ['overrideParams', 'kind', 'story', 'to'],
       },
     ],
     'no-underscore-dangle': [
       error,
-      {
-        allow: ['__STORYBOOK_CLIENT_API__', '__STORYBOOK_ADDONS_CHANNEL__'],
-      },
+      { allow: ['__STORYBOOK_CLIENT_API__', '__STORYBOOK_ADDONS_CHANNEL__'] },
     ],
   },
   overrides: [
     {
-      files: ['**/__tests__/**', '**/*.test.js/**', '**/*.spec.js/**'],
+      files: ['**/__tests__/**', '**/*.test.js', '**/*.spec.js', '**/*.stories.js'],
       rules: {
         'import/no-extraneous-dependencies': ignore,
       },
     },
     {
       files: ['**/react-native*/**', '**/REACT_NATIVE*/**', '**/crna*/**'],
-      rules: {
-        'jsx-a11y/accessible-emoji': ignore,
-      },
-    },
-    {
-      files: '**/.storybook/config.js',
-      rules: {
-        'global-require': ignore,
-      },
+      rules: { 'jsx-a11y/accessible-emoji': ignore },
     },
+    { files: '**/.storybook/config.js', rules: { 'global-require': ignore } },
   ],
 };
diff --git a/.spelling b/.spelling
@@ -64,12 +64,10 @@ HMR
 Redux
 storybook-ui
 react-komposer
-redux
 serializable
 params
- - addons/actions/node_modules/@storybook/addons/README.md
+README.md
 storybooks.js.org
- - addons/actions/node_modules/asap/README.md
 YuzuJS
 setImmediate
 Malte
@@ -78,15 +76,11 @@ Katić
 Domenic
 Kowal
 Zakas
- - addons/actions/node_modules/balanced-match/README.md
 Gruber
 julian
 juliangruber.com
- - addons/actions/node_modules/brace-expansion/README.md
 Schlueter
- - addons/links/README.md
 linkTo
- - lib/ui/README.md
 setOptions
 setStories
 onStory
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -282,9 +282,9 @@ First we are going to install storybook, then we are going to link `@storybook/r
 
 #### Verify your local version is working
 
-You should now have a working storybook dev environment up and running. To verify this you can make changes to the following file:
+You should now have a working storybook dev environment up and running. 
 
-`open app/react/src/client/manager/preview.js`
+> TODO: update this section (is already incorrect)
 
 Save and go to `http://localhost:9009` (or wherever storybook is running)
 

diff --git a/LICENSE b/LICENSE
@@ -14,7 +14,7 @@ all copies or substantial portions of the Software.
 
 THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+FITNESS FOR A PARTICULAR PURPOSE AND NON-INFRINGEMENT. IN NO EVENT SHALL THE
 AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN

diff --git a/README.md b/README.md
@@ -149,12 +149,16 @@ If you're looking for material to use in your presentation about storybook, like
 
 ## Contributing
 
-[![Good First Issue](https://img.shields.io/github/issues/storybooks/storybook/good%20first%20issue.svg)](https://github.com/storybooks/storybook/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22)
-
 We welcome contributions to Storybook!
 
-- ⇄ Pull requests and ★ Stars are always welcome.
+- 📥 Pull requests and 🌟 Stars are always welcome.
 - Read our [contributing guide](CONTRIBUTING.md) to get started.
+  or find us on [Discord](https://discord.gg/sMFvFsG), we're will take the time to guide you 
+
+Looking for a first issue to tackle? 
+
+- We tag issues with [![Good First Issue](https://img.shields.io/github/issues/storybooks/storybook/good%20first%20issue.svg)](https://github.com/storybooks/storybook/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) when we think they are well suited for people who are new to the codebase or OSS in general.
+- [Talk to us](https://discord.gg/sMFvFsG), we'll find something to suits your skills and learning interest.
 
 ### Development scripts
 

diff --git a/WORKLOG.md b/WORKLOG.md
@@ -0,0 +1,57 @@
+@ndelangen
+TODO:
+- [x] FIX navigate by keyboard shortcut
+- [x] FIX addon-storysource click navigate
+- [x] FIX addon-links
+- [x] FIX addon-actions
+- [ ] FIX when reloading page selected story should stay (this happens when there's a mismatch between hierarchySeparators)
+
+- [ ] INVESTIGATE if addon-storysource can use router directly over state method
+- [ ] DISCUSS moving router into a separate package
+
+- [ ] TEST other examples (vue with it's different `decorateStory`)
+
+- [x] FIX HMR - stick with story in url
+- [x] FIX HMR - HMR in ejected iframe
+- [ ] FIX HMR - keep state of explorer
+
+- [x] FIX http://localhost:9011/?path=/components/Core-Errors-storyErrors (should error)
+- [ ] FIX https://deploy-preview-4086--storybooks-official.netlify.com/?selectedKind=Addons%7Ca11y&selectedStory=Invalid%20contrast&full=0&addons=1&stories=1&panelRight=0&addonPanel=%40storybook%2Faddon-a11y%2Fpanel (should redirect correctly)
+
+- [x] OPTIMIZE double selectStory event
+- [x] OPTIMIZE selectStory event at fullscreen switch
+- [ ] unify SET_CURRENT_STORY & SELECT_STORY
+
+- [x] FIX eslint
+- [ ] ADD unit tests
+
+- [x] REMOVE zoom level text & ADD reset button
+- [x] REMOVE grid-lines or move into addons / toggle
+- [x] FIX refresh when toggle panel or nav
+- [ ] FIX main is weird when entry page is settings after switching to components
+- [x] FIX delay in resizing panels because of transition
+
+- [ ] ADD postMessage to ejected iframe
+
+- [x] REMOVE toNested
+- [ ] ADD explorer hover over items
+- [ ] ADD support for rootSeparators in explorer
+- [ ] ADD auto-open of selection in explorer
+- [ ] ADD explorer empty message
+- [ ] ADD highlighting of the search results
+- [ ] TRY - when you click on a group, maybe select first renderable child - in an option?
+
+- [ ] ADD fetching of data for version notification
+- [ ] ADD storage of version info in localStorage
+
+Dom's changes
+- [x] ADD tools/hotkeys button
+- [x] ADD UI to go fullscreen and toggle panels
+- [ ] CHANGE styles of explorer
+- [ ] CHANGE styles of notifications
+- [x] CHANGE styles of main (preview+panel)
+- [ ] CHANGE toolbar
+- [ ] ADD shortcut for toggle toolbar
+- [ ] ADD shortcut for zoom
+- [ ] ADD shortcut for toggle grid
+- [ ] ADD tools to TabsBar
diff --git a/addons/a11y/README.md b/addons/a11y/README.md
@@ -11,7 +11,7 @@ This storybook addon can be helpful to make your UI components more accessible.
 First, install the addon.
 
 ```sh
-$ npm install -D @storybook/addon-a11y
+$ yarn add @storybook/addon-a11y --dev
 ```
 
 Add this line to your `addons.js` file (create this file inside your storybook config directory if needed).
@@ -20,16 +20,18 @@ Add this line to your `addons.js` file (create this file inside your storybook c
 import '@storybook/addon-a11y/register';
 ```
 
-import the `'checkA11y'` decorator to check your stories for violations within your components.
+import the `withA11Y` decorator to check your stories for violations within your components.
 
 ```js
 import React from 'react';
 import { storiesOf } from '@storybook/react';
+import { withA11Y } from '@storybook/addon-a11y';
 
-import { checkA11y } from '@storybook/addon-a11y';
+// should only be added once
+// best place is in config.js
+addDecorator(withA11Y)
 
 storiesOf('button', module)
-  .addDecorator(checkA11y)
   .add('Accessible', () => (
     <button>
       Accessible button
@@ -42,55 +44,35 @@ storiesOf('button', module)
   ));
 ```
 
-For more customizability. Use the `'configureA11y'` function to configure [aXe options](https://github.com/dequelabs/axe-core/blob/develop/doc/API.md#api-name-axeconfigure).
+For more customizability. Use the `addParameters` function to configure [aXe options](https://github.com/dequelabs/axe-core/blob/develop/doc/API.md#api-name-axeconfigure).
+You can override these options at story level too.
 
 ```js
 import React from 'react';
-import { storiesOf } from '@storybook/react';
+import { storiesOf, addDecorator, addParameters } from '@storybook/react';
 
-import { checkA11y, configureA11y } from '@storybook/addon-a11y';
+import { withA11Y } from '@storybook/addon-a11y';
 
-const whateverOptionsYouWant = {};
-configureA11y(whateverOptionsYouWant);
+addDecorator(withA11Y)
+addParameters({ a11y: {} });
 
 storiesOf('button', module)
-  .addDecorator(checkA11y)
   .add('Accessible', () => (
-    <button>
+    <button style={{ backgroundColor: 'black', color: 'white', }}>
       Accessible button
     </button>
   ))
   .add('Inaccessible', () => (
-    <button style={{ backgroundColor: 'red', color: 'darkRed', }}>
+    <button style={{ backgroundColor: 'black', color: 'black', }}>
       Inaccessible button
     </button>
   ));
 ```
 
-If you want to add a11y globally to your stories, you can use the global Storybook decorator in your *.storybook/config.js* file:
-
-```js
-import { configure, addDecorator } from '@storybook/react';
-import { checkA11y } from '@storybook/addon-a11y';
-
-// pick all stories.js files within the src/ folder
-const req = require.context('../src', true, /stories\.js$/);
-
-addDecorator(checkA11y);
-
-function loadStories() {
-  req.keys().forEach(filename => req(filename));
-}
-
-configure(loadStories, module);
-```
-
 ## Roadmap
 
 * Make UI accessibile
-* Add color blindness filters ([Example](http://lowvision.support/))
 * Show in story where violations are.
-* Make it configurable
 * Add more example tests
 * Add tests
 * Make CI integration possible
diff --git a/addons/a11y/manager.js b/addons/a11y/manager.js
diff --git a/addons/a11y/package.json b/addons/a11y/package.json
@@ -25,19 +25,19 @@
     "prepare": "node ../../scripts/prepare.js"
   },
   "dependencies": {
-    "@emotion/styled": "^0.10.6",
+    "@emotion/styled": "^10.0.2",
     "@storybook/addons": "4.2.0-alpha.2",
     "@storybook/client-logger": "4.2.0-alpha.2",
     "@storybook/components": "4.2.0-alpha.2",
     "@storybook/core-events": "4.2.0-alpha.2",
     "axe-core": "^3.1.2",
     "core-js": "^2.5.7",
+    "react": "^16.7.0-alpha.2",
+    "react-dom": "^16.7.0-alpha.2",
     "global": "^4.3.2",
-    "prop-types": "^15.6.2"
-  },
-  "peerDependencies": {
-    "react": "*",
-    "react-dom": "*"
+    "memoizerific": "^1.11.3",
+    "prop-types": "^15.6.2",
+    "util-deprecate": "^1.0.2"
   },
   "publishConfig": {
     "access": "public"

diff --git a/addons/a11y/register.js b/addons/a11y/register.js
@@ -1 +1 @@
-require('./manager');
+require('./dist/register');