Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set zone.js as a peer and dev dependency #4663

Merged
merged 2 commits into from
Nov 5, 2018
Merged

Set zone.js as a peer and dev dependency #4663

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c79f134
Set zone.js as a peer and dev dependency
emilio-martinez Oct 31, 2018
2424fec
Merge branch 'master' into fix/angular-zone-dep
Hypnosphi Nov 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions app/angular/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@
"sass-loader": "^7.1.0",
"ts-loader": "^5.2.2",
"tsconfig-paths-webpack-plugin": "^3.2.0",
"webpack": "^4.23.1",
"zone.js": "^0.8.26"
"webpack": "^4.23.1"
},
"peerDependencies": {
"@angular-devkit/core": "^0.6.1 || >=7.0.0",
Expand All @@ -51,6 +50,10 @@
"@angular/forms": ">=6.0.0",
"@angular/platform-browser": ">=6.0.0",
"@angular/platform-browser-dynamic": ">=6.0.0",
"babel-loader": "^7.0.0 || ^8.0.0"
"babel-loader": "^7.0.0 || ^8.0.0",
"zone.js": "^0.8.26"
},
"devDependencies": {
"zone.js": "^0.8.26"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroeder should we add zone.js in cli?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean when running sb init? No, there's no angular without zone.js installed. ng new my-app already does add zone.js, angular does not work without it - We do not need to take care of this

https://medium.com/@MertzAlertz/what-the-hell-is-zone-js-and-why-is-it-in-my-angular-2-6ff28bcf943e

Let’s do an experiment. Go and take your favorite Angular 2 app, and don’t include zone.js. See what happens, I’ll wait here. Notice anything interesting? None of the bindings are working!

}
}