-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CRA TypeScript support for .storybook folder #4902
Add CRA TypeScript support for .storybook folder #4902
Conversation
@igor I found a strange issue, unrelated, where this config is loaded twice - you can see that it's happening because it logs the action twice in the terminal. I've safeguarded against this for now, but we should look to resolve it - unfortunately I don't have time this weekend. I'll create an issue for it. |
Yeah, it is a "known" thing. We apply presets on |
Codecov Report
@@ Coverage Diff @@
## next #4902 +/- ##
==========================================
+ Coverage 34.84% 34.98% +0.13%
==========================================
Files 566 566
Lines 7005 7009 +4
Branches 937 938 +1
==========================================
+ Hits 2441 2452 +11
+ Misses 4064 4060 -4
+ Partials 500 497 -3
Continue to review full report at Codecov.
|
@igor-dv Thanks for the feedback. PR updated, and I also added tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
Issue: #4587 (comment)
What I did
Allowed the use of
.ts
and.tsx
files in the.storybook
folder. This was not in scope initially, but was added on request.How to test
When using with CRA and TypeScript, rename your
config.js
toconfig.tsx
in the.storybook
folder.