-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TypeScript CRA example #5011
Conversation
FIX react native by adding an empty array named dlls to the templateParameters
@shilman Can you help me with broken build? Looks like its totally not related to the changes I have made. Would be very helpful to move this forward |
Codecov Report
@@ Coverage Diff @@
## next #5011 +/- ##
=======================================
Coverage 34.85% 34.85%
=======================================
Files 579 579
Lines 7038 7038
Branches 943 943
=======================================
Hits 2453 2453
Misses 4082 4082
Partials 503 503 Continue to review full report at Codecov.
|
23abbfb
to
4d6a7c2
Compare
This PR is containing changes from wrong commits (probably needs a merge from |
I can see that storybook itself is migrating over TypeScript. Its a very popular setup. Because of that I thought it makes sence to have a similar example setup as well. It looks easy now but I spent half a day to make it working as it required quite a bit of investigation. IMO if this is out of monorepo less people will find it. Right now there is quite long documentation related to TypeScript. Maybe we can just point to this example? What do you think? |
@mucsi96, mind solve the conflicts + fix the linter? |
@igor-dv Sure! Will create a new PR from scratch based on |
Issue:
What I did
I have created an example incorporating CRA2, TypeScript, TSLint, Jest, Enzyme
Closes #5006