Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tech/overhaul ui new story #5072

Merged
merged 14 commits into from
Jan 3, 2019
Merged

Tech/overhaul ui new story #5072

merged 14 commits into from
Jan 3, 2019

Conversation

tmeasday
Copy link
Member

Changing some things about the way we identify stories:

  1. renaming from componentId => storyId
  2. Changing the format to something like root-group-group--story

@tmeasday tmeasday requested a review from ndelangen December 21, 2018 06:01
@storybook-safe-bot
Copy link
Contributor

storybook-safe-bot commented Dec 21, 2018 •
edited
Loading

Fails
🚫 PR is marked with "do not merge" label.
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 673f015

@tmeasday
Copy link
Member Author

@ndelangen let's merge this?

@tmeasday tmeasday merged commit 85182cd into tech/overhaul-ui Jan 3, 2019
@tmeasday tmeasday deleted the tech/overhaul-ui-new-storyId branch January 3, 2019 10:32
@shilman shilman added the maintenance User-facing maintenance tasks label Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndelangen ndelangen Awaiting requested review from ndelangen

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@alterx alterx Awaiting requested review from alterx

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv

@thomasbertet thomasbertet Awaiting requested review from thomasbertet

Assignees

@ndelangen ndelangen

Labels
ci: do not merge maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmeasday @storybook-safe-bot @shilman @ndelangen