Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround the dev cli -h shorthand conflict #5464

Merged

Conversation

pascalduez
Copy link
Contributor

@pascalduez pascalduez commented Feb 3, 2019

Issue:

It fixes #5360

What I did

A little workaround so that both -h shorthands behave in a more expected manner.

How to test

  • Is this testable with Jest or Chromatic screenshots? Nope
  • Does this need a new example in the kitchen sink apps? Nope
  • Does this need an update to the documentation? Nope

@storybook-safe-bot
Copy link
Contributor

storybook-safe-bot commented Feb 3, 2019

Fails
🚫

PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against 385b518

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #5464 into next will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5464      +/-   ##
==========================================
- Coverage   31.38%   31.37%   -0.02%     
==========================================
  Files         635      635              
  Lines        9190     9193       +3     
  Branches     1271     1272       +1     
==========================================
  Hits         2884     2884              
- Misses       5666     5668       +2     
- Partials      640      641       +1
Impacted Files Coverage Δ
lib/core/src/server/cli/dev.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ca1ab...385b518. Read the comment docs.

@ndelangen ndelangen added this to the v5.0.0 milestone Feb 4, 2019
@ndelangen ndelangen merged commit cf6e494 into storybookjs:next Feb 4, 2019
@pascalduez pascalduez deleted the hotfix/cli-h-shorthand-conflict branch August 17, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

start-storybook cli flag conflict
4 participants