Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD default backgrounds to official example #5585

Merged
merged 2 commits into from
Feb 14, 2019

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 14, 2019

Issue:

  • the backgrounds addon is not usable in official example
  • the preview is not scrollable
  • image capture from storyshots-puppeteer don't match
  • all chromatic images have backgrounds changed

What I did

ADD a background list for all stories in the official example
CHANGE createGlobal back to createReset, move the no scroll properties to createGlobal

@ndelangen ndelangen added the bug label Feb 14, 2019
@ndelangen ndelangen added this to the v5.0.0 milestone Feb 14, 2019
@ndelangen ndelangen self-assigned this Feb 14, 2019
@codecov
Copy link

codecov bot commented Feb 14, 2019

Codecov Report

Merging #5585 into next will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5585      +/-   ##
==========================================
- Coverage   33.21%   33.21%   -0.01%     
==========================================
  Files         647      647              
  Lines        9314     9313       -1     
  Branches     1349     1349              
==========================================
- Hits         3094     3093       -1     
  Misses       5605     5605              
  Partials      615      615
Impacted Files Coverage Δ
lib/ui/src/components/panel/panel.stories.js 100% <ø> (ø) ⬆️
lib/theming/src/global.ts 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c6d6ba...dfad77b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants