Use the correct props to start the tooltip open #5610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Thanks @tmeasday! |
domyen
approved these changes
Feb 15, 2019
|
Not sure what's happening with the build but I will merge and fix if it continues |
Codecov Report
@@ Coverage Diff @@
## next #5610 +/- ##
=======================================
Coverage ? 32.99%
=======================================
Files ? 638
Lines ? 9236
Branches ? 1313
=======================================
Hits ? 3047
Misses ? 5550
Partials ? 639
Continue to review full report at Codecov.
|
shilman
added
the
patch:done
shilman
pushed a commit
that referenced
this pull request
Feb 19, 2019
Use the correct props to start the tooltip open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5591
The
startOpenprop is for the statefulWithTooltipState(ie. the one that can open and close).To get an always open one, use
tooltipOpenon theWithTooltip. I assume this is what you wanted @domyen?PS It seems backwards to export the stateless one as the default @ndelangen. But I guess you are against default exports full stop...