Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-Jest: Fix event subscription #5644

Merged
merged 1 commit into from
Feb 18, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Feb 18, 2019

Issue: #5197

What I did

Subscribe to the right event

How to test

See addon-jest story in official-storybook

@codecov
Copy link

codecov bot commented Feb 18, 2019

Codecov Report

Merging #5644 into next will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #5644      +/-   ##
==========================================
- Coverage   33.25%   33.25%   -0.01%     
==========================================
  Files         648      648              
  Lines        9325     9326       +1     
  Branches     1349     1349              
==========================================
  Hits         3101     3101              
- Misses       5609     5610       +1     
  Partials      615      615
Impacted Files Coverage Δ
addons/jest/src/index.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6fcf41...0957242. Read the comment docs.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow that was easier than I'd hoped!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
addon: jest bug patch:done Patch/release PRs already cherry-picked to main/release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants