Fix #5785 - welcome component in dark theme #5998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malykhinvi
requested review from
alexandrebodin,
alterx,
danielduan,
Hypnosphi,
igor-dv,
ndelangen,
shilman,
stijnkoopal,
thomasbertet and
usulpro
as code owners
shilman
added
bug
cli
patch:yes
shilman
approved these changes
Mar 10, 2019
Codecov Report
@@ Coverage Diff @@
## next #5998 +/- ##
==========================================
- Coverage 34.93% 34.92% -0.01%
==========================================
Files 648 648
Lines 9515 9512 -3
Branches 1380 1379 -1
==========================================
- Hits 3324 3322 -2
+ Misses 5574 5573 -1
Partials 617 617
Continue to review full report at Codecov.
|
shilman
added
the
patch:done
shilman
added
patch:done
shilman
added a commit
that referenced
this pull request
Mar 15, 2019
Fix #5785 - welcome component in dark theme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5785 - missing background in the Welcome component makes content unreadable in dark theme.
What I did
/demo"Welcome" components/examples"Welcome" componentsmargintopadding, so there would be bigger gap between container and contentHow to test
Yes, I updated jest snapshots. It can be tested with some visual regression testing tool, but I'm not sure what is the proper way to do it here.
No
No
I checked all kitchen-sink examples. Also I set up storybook in one of my react projects, and run storybook with linked
@storybook/react. Looks like it works, however, I didn't check cli with other frameworks.Below you can find before/after screenshots
