Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround broken treebeard animations #6249

Merged
merged 2 commits into from
Mar 24, 2019
Merged

Workaround broken treebeard animations #6249

merged 2 commits into from
Mar 24, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Mar 24, 2019

Issue: #6248

What I did

Disable sidebar animations by default

This means that treebeard won't create velocity-react transition elements, which are apparently broken for reasons I don't understand.

How to test

UI will break per #6248 before this change, and be fixed after this change:

rm yarn.lock # forces the latest version of react?
yarn bootstrap --reset --core
cd examples/official-storybook
yarn storybook

@shilman shilman added this to the 5.0.x milestone Mar 24, 2019
@shilman
Copy link
Member Author

shilman commented Mar 24, 2019

Self-merging because this is breaking people and I'm confident that it's a safe fix

@shilman shilman merged commit 8397264 into release/4.x Mar 24, 2019
@shilman shilman deleted the 6248-treebeard-workaround branch March 24, 2019 07:14
@shilman shilman mentioned this pull request Mar 24, 2019
Closed
@Ron-Lavi
Copy link

Ron-Lavi commented Mar 24, 2019 •
edited
Loading

Hi, thanks for the great work 👍
is it a valid fix for older versions ? in our project we have used v3.4.11 with webpack 3,
what is the best solution here? thanks

@shilman
Copy link
Member Author

shilman commented Mar 24, 2019

@LaViro aha it's also broken for 3.x? I'll fix that too

@shilman
Copy link
Member Author

shilman commented Mar 24, 2019

@LaViro https://github.com/storybooks/storybook/releases/tag/v3.4.12

@Ron-Lavi
Copy link

Thanks for the fast response :) works great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielduan danielduan Awaiting requested review from danielduan danielduan is a code owner

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi Hypnosphi is a code owner

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@ndelangen ndelangen Awaiting requested review from ndelangen ndelangen is a code owner

@tmeasday tmeasday Awaiting requested review from tmeasday tmeasday is a code owner

@usulpro usulpro Awaiting requested review from usulpro usulpro is a code owner

Assignees
No one assigned
Labels
bug ui
Projects
None yet
Milestone
5.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @Ron-Lavi