Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix react-native preview only ui #6549

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Fix react-native preview only ui #6549

merged 2 commits into from
Apr 17, 2019

Conversation

benoitdion
Copy link
Member

@benoitdion benoitdion commented Apr 17, 2019

Issue

After the typescript migration (#6448) a couple regressions were introduced.

What I did

Fixed the above issues, see individual commits for more details.

How to test

  • Run the storybook for react-native with onDeviceUI true and false. Switch between stories using the web ui.

The story isn't set until we receive the first channel event
@vercel
Copy link

vercel bot commented Apr 17, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-react-native-bugs.storybook.now.sh

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #6549 into next will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #6549      +/-   ##
==========================================
- Coverage   40.77%   40.76%   -0.01%     
==========================================
  Files         616      616              
  Lines        8529     8531       +2     
  Branches      595      596       +1     
==========================================
  Hits         3478     3478              
- Misses       4959     4961       +2     
  Partials       92       92
Impacted Files Coverage Δ
...-native/src/preview/components/StoryView/index.tsx 0% <0%> (ø) ⬆️
app/react-native/src/preview/index.tsx 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 165a5f6...d5d785d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants