Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX viewmode being hard-coded making custom addons of type TAB impossible #6551

Merged
merged 4 commits into from
Apr 18, 2019

Conversation

ndelangen
Copy link
Member

Issue:
I was documenting the TAB addon type, and discovered we had the info and story viewmodes hardcoded, this meant it was pretty much impossible to create custom viewmodes & thus addons of type TAB.

This PR changes the way we detect whether we're in /settings/xyz.

Now addons can easily create their own TAB! no hassle.

What I did

FIX router & desktop layout, which made it impossible to add custom viewmodes

@vercel
Copy link

vercel bot commented Apr 17, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fix-addon-tab-type.storybook.now.sh

@codecov
Copy link

codecov bot commented Apr 17, 2019

Codecov Report

Merging #6551 into next will not change coverage.
The diff coverage is 50%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #6551   +/-   ##
=======================================
  Coverage   40.77%   40.77%           
=======================================
  Files         616      616           
  Lines        8530     8530           
  Branches      596      596           
=======================================
  Hits         3478     3478           
  Misses       4960     4960           
  Partials       92       92
Impacted Files Coverage Δ
lib/ui/src/components/layout/layout.stories.js 82.35% <ø> (ø) ⬆️
lib/ui/src/components/layout/desktop.js 100% <ø> (ø) ⬆️
lib/router/src/utils.ts 51.61% <50%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1d00be...37a519c. Read the comment docs.

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants