-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX viewmode being hard-coded making custom addons of type TAB impossible #6551
Conversation
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-addon-tab-type.storybook.now.sh |
Codecov Report
@@ Coverage Diff @@
## next #6551 +/- ##
=======================================
Coverage 40.77% 40.77%
=======================================
Files 616 616
Lines 8530 8530
Branches 596 596
=======================================
Hits 3478 3478
Misses 4960 4960
Partials 92 92
Continue to review full report at Codecov.
|
a7fb971
to
37a519c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Issue:
I was documenting the TAB addon type, and discovered we had the
info
andstory
viewmodes hardcoded, this meant it was pretty much impossible to create custom viewmodes & thus addons of type TAB.This PR changes the way we detect whether we're in
/settings/xyz
.Now addons can easily create their own TAB! no hassle.
What I did
FIX router & desktop layout, which made it impossible to add custom viewmodes