Pass all files other then node_modules though babel loader by default #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REMOVE the include lists for the babel-loader, this should enable transpiling for files other then in your source directory, making the need for custom webpack configs less prominent ADD a thread-loader to hopefully speed up the building of large storybooks
ndelangen
added
configuration babel / webpack
maintenance
ndelangen
requested review from
alterx,
danielduan,
igor-dv,
tmeasday and
usulpro
as code owners
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-tech-loader-scope-changes.storybook.now.sh |
ndelangen
changed the title
Codecov Report
@@ Coverage Diff @@
## next #6566 +/- ##
=========================================
+ Coverage 40.4% 45.33% +4.92%
=========================================
Files 637 638 +1
Lines 8778 8799 +21
Branches 643 644 +1
=========================================
+ Hits 3547 3989 +442
+ Misses 5133 4697 -436
- Partials 98 113 +15
Continue to review full report at Codecov.
|
ndelangen
requested review from
aaronmcadam,
alexandrebodin,
CodeByAlex,
dangreenisrael and
jbovenschen
as code owners
ndelangen
removed request for
Gongreg,
stijnkoopal,
jbovenschen,
renaudtertrais,
usulpro,
dangreenisrael,
naipath,
z4o4z and
rmevans9
Merged
# Conflicts: # .gitignore # addons/actions/package.json # addons/backgrounds/package.json # addons/contexts/src/manager/libs/useChannel.ts # addons/contexts/src/preview/api.ts # addons/contexts/src/register.ts # addons/cssresources/package.json # addons/events/package.json # addons/google-analytics/package.json # addons/info/package.json # addons/jest/package.json # addons/notes/package.json # addons/ondevice-backgrounds/package.json # addons/ondevice-knobs/package.json # addons/ondevice-notes/package.json # addons/options/package.json # addons/storyshots/storyshots-core/package.json # addons/storyshots/storyshots-puppeteer/package.json # addons/storysource/package.json # addons/viewport/package.json # examples/angular-cli/jest.config.js # examples/official-storybook/webpack.config.js # lib/addons/package.json # lib/addons/src/index.ts # lib/addons/src/public_api.ts # lib/api/package.json # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/components/package.json # lib/core-events/src/index.ts # lib/router/package.json # lib/ui/package.json # yarn.lock
linting is broken, type exports are still imported, which causes errors, type imports aren't found
# Conflicts: # addons/actions/package.json # addons/backgrounds/package.json # addons/cssresources/package.json # addons/events/package.json # addons/google-analytics/package.json # addons/info/package.json # addons/jest/package.json # addons/notes/package.json # addons/ondevice-backgrounds/package.json # addons/ondevice-knobs/package.json # addons/ondevice-notes/package.json # addons/options/package.json # addons/storyshots/storyshots-core/package.json # addons/storyshots/storyshots-puppeteer/package.json # addons/storysource/package.json # addons/viewport/package.json # app/react-native-server/src/client/manager/provider.js # app/react-native/src/preview/components/OnDeviceUI/addons/index.tsx # app/react-native/src/preview/components/StoryListView/index.tsx # app/react-native/src/preview/components/StoryView/index.tsx # lib/addons/package.json # lib/api/package.json # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/components/package.json # lib/router/package.json # lib/ui/package.json
# Conflicts: # .babelrc.js # addons/actions/package.json # addons/backgrounds/package.json # addons/cssresources/package.json # addons/events/package.json # addons/google-analytics/package.json # addons/graphql/package.json # addons/info/package.json # addons/jest/package.json # addons/notes/package.json # addons/ondevice-backgrounds/package.json # addons/ondevice-knobs/package.json # addons/ondevice-notes/package.json # addons/options/package.json # addons/storyshots/storyshots-core/package.json # addons/storyshots/storyshots-core/src/frameworks/angular/loader.js # addons/storyshots/storyshots-puppeteer/package.json # addons/storysource/package.json # addons/viewport/package.json # app/angular/package.json # examples/cra-kitchen-sink/jest.config.js # jest.config.js # lib/addons/package.json # lib/api/package.json # lib/channel-postmessage/package.json # lib/channel-websocket/package.json # lib/components/package.json # lib/core/package.json # lib/core/src/server/common/babel.js # lib/core/src/server/common/polyfills.js # lib/core/src/server/manager/manager-webpack.config.js # lib/core/src/server/preview/iframe-webpack.config.js # lib/router/package.json # lib/theming/src/index.ts # lib/ui/package.json # lib/ui/scripts/createDlls.js # yarn.lock
This was referenced Jan 15, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #6047
What I did
REMOVE the include lists for the babel-loader, this should enable transpiling for files
other then in your source directory, making the need for custom webpack configs less prominent.
ADD a thread-loader to hopefully speed up the building of large storybooks.
ADD a loader for css and a file-loader for other files.
Storybook will now transpile all files through babel as long as
/node_modules/doesn't exists in the file's path.This is a breaking change
This makes it easier for users to write their addons locally and have them be transpiled by webpack/babel.
UPGRADE to core-js 3
REMOVE alias for core-js
CHANGE transpile strategy: transpile to ES modules for better tree-shaking.