Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-contexts: Improve Vue integration #6632

Merged
merged 5 commits into from
Apr 26, 2019
Merged

Addon-contexts: Improve Vue integration #6632

merged 5 commits into from
Apr 26, 2019

Conversation

leoyli
Copy link
Contributor

@leoyli leoyli commented Apr 25, 2019 •
edited
Loading

Issue: #6631

What I did

  • [improve] Improve Vue integration so it receive a similar working experiences as in React.
  • [add] 2 stories being add into Vue-kitchen-sink (mirror to the official React examples).

How to test

Live example:
https://monorepo-git-add-addon-contextsvue-i.storybook.now.sh/examples/vue-kitchen-sink/?path=/story/addon-contexts--languages&contexts=Languages=French,CSS%20Themes=Desert

@leoyli leoyli added this to the 5.1.0 milestone Apr 25, 2019
@leoyli leoyli self-assigned this Apr 25, 2019
@vercel
Copy link

vercel bot commented Apr 25, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-add-addon-contextsvue-i.storybook.now.sh

@vercel vercel bot temporarily deployed to staging April 25, 2019 18:49 Inactive
@vercel vercel bot temporarily deployed to staging April 25, 2019 18:51 Inactive
@leoyli
Copy link
Contributor Author

leoyli commented Apr 25, 2019

Uh... sorry I forget to commit the snapshot files, a commit is coming up 💪

@leoyli leoyli added the vue label Apr 25, 2019
@leoyli
Copy link
Contributor Author

leoyli commented Apr 25, 2019

@shilman... it seems some linting errors from files other than the scope of this PR?! Is any quick fix or I just ignore it?!

leoyli
leoyli commented Apr 25, 2019
View reviewed changes
examples/vue-kitchen-sink/src/stories/addon-contexts.stories.js
`,
},
};
};
Copy link
Contributor Author

@leoyli leoyli Apr 25, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the createContext in React is really well-designed, so I'm also thinking to make this util component a standalone package or as a helper in the addon. I have google and look into NPM registry, few examples or ideal implementation (vue2.6 changed something so they seems a bit outdated)...

Copy link
Contributor Author

@leoyli leoyli Apr 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have published the latest implementation for this util component: vue-create-context with some minor improvements. But I think we can just merge this PR since it is not super long and working well (or maybe just copy past the latest source code from my repo)?!

shilman
shilman approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! 🚀

@shilman shilman changed the title Add/addon contexts/vue intergration Addon-contexts: Improve vue integration Apr 25, 2019
@shilman shilman changed the title Addon-contexts: Improve vue integration Addon-contexts: Improve Vue integration Apr 25, 2019
@shilman shilman merged commit 9bb3ae8 into next Apr 26, 2019
@shilman shilman deleted the add/addon-contexts/vue-intergration branch April 26, 2019 03:14
@shilman shilman mentioned this pull request Apr 26, 2019
Closed
This was referenced Jan 15, 2021
Closed
Merged
This was referenced Jan 15, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

@elevatebart elevatebart Awaiting requested review from elevatebart

@alexandrebodin alexandrebodin Awaiting requested review from alexandrebodin

@igor-dv igor-dv Awaiting requested review from igor-dv

Assignees

@leoyli leoyli

Labels
addon: contexts feature request vue
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leoyli @shilman