Fix/refresh iframe #6787
Merged
Fix/refresh iframe #6787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…message has arrived from preview
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-refresh-iframe.storybook.now.sh |
shilman
reviewed
May 15, 2019
tmeasday
approved these changes
May 15, 2019
There was a problem hiding this comment.
Seems like a good approach to me. Thanks for fixing my mess @ndelangen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
#6688
#5925
What I did
This changes the Iframe component code, so it no longer updates
This changes the postmessage channel so it only flushes the buffer after receiving the first message from the iframe (this pretty much ensures the channel is set up there to receive messages as well). This is a better method then the DOMdocumentReady event.