Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation: it's -> its #7138

Merged
merged 1 commit into from
Jun 18, 2019
Merged

documentation: it's -> its #7138

merged 1 commit into from
Jun 18, 2019

Conversation

piperchester
Copy link
Contributor

Simple typo fix.

@vercel
Copy link

vercel bot commented Jun 18, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-fork-piperchester-patch-4.storybook.now.sh

@piperchester piperchester changed the title docs: it's -> its documentation: it's -> its Jun 18, 2019
@piperchester
Copy link
Contributor Author

Fails
🚫
PR is not labeled with one of: ["cleanup","doc-dependencies:update","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS against e34cc35

Love DangerJS and this integration! I'd be curious to see if we can modify the danger config to support docs: as a valid option to support semantic commits.

shilman
shilman approved these changes Jun 18, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@shilman shilman added documentation patch:yes Bugfix & documentation PR that need to be picked to main branch labels Jun 18, 2019
@shilman shilman added this to the 5.1.x milestone Jun 18, 2019
@shilman shilman merged commit 84a503d into storybookjs:next Jun 18, 2019
@piperchester piperchester deleted the patch-4 branch June 18, 2019 21:28
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Jun 27, 2019
@dependencies dependencies bot mentioned this pull request Jan 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@ndelangen ndelangen Awaiting requested review from ndelangen

Assignees
No one assigned
Labels
documentation patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
5.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@piperchester @shilman