extend devMiddlewareOptions with config.devServer #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moimikey
force-pushed
the
extend-webpack-middleware
branch
from
0ee982e
to
ec6c41e
Compare
|
I need to take a look at this, I wondering if there's a way to add tests for this? |
|
i'll give it a shot |
|
Awesome! I'll try to review it regardless. |
Merged
|
^_~ |
ndelangen
approved these changes
Apr 12, 2017
|
Thank you @moimikey ! |
|
👍 🌈 |
wildeyes
reviewed
Sep 3, 2017
| @@ -25,6 +25,7 @@ export default function (configDir) { | |||
| noInfo: true, | |||
| publicPath: config.output.publicPath, | |||
| watchOptions: config.watchOptions || {}, | |||
| ...config.devServer, | |||
There was a problem hiding this comment.
Where can I pass the config.devServer to, to manipulate these configurations?
There was a problem hiding this comment.
Should be in the webpack.config.js export I'm pretty sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
notes
since
devMiddlewareOptionsis pretty much the same asdevServer, this simply allows a webpack config to naturally usedevServerto override the defaultdevMiddlewareOptionsfixes #650