Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX addon-actions performance issue #7256

Merged
merged 1 commit into from
Jul 2, 2019
Merged

FIX addon-actions performance issue #7256

merged 1 commit into from
Jul 2, 2019

Conversation

ndelangen
Copy link
Member

Issue:

Serialising functions takes a lot of time/CPU, the default setup where, actions gets transferred across the channel including methods & functions is slow.

Related:
#6287

What I did

ADD support for allowFunction boolean option on telejson & set default value for action to false.

How to test

By default the data passed to action will sanitised from functions,
I added a case

@ndelangen ndelangen added this to the 5.2.0 milestone Jul 2, 2019
@ndelangen ndelangen self-assigned this Jul 2, 2019
@vercel
Copy link

vercel bot commented Jul 2, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-tech-improve-serialization-performance.storybook.now.sh

@ndelangen ndelangen changed the title … FIX addon-actions performance issue Jul 2, 2019
shilman
shilman approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen ndelangen merged commit 3b2ef9b into next Jul 2, 2019
@ndelangen ndelangen deleted the tech/improve-serialization-performance branch July 2, 2019 23:34
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Jul 26, 2019
shilman pushed a commit that referenced this pull request Jul 31, 2019
@ndelangen @shilman
FIX addon-actions performance issue (#7256)
2046e90 
FIX addon-actions performance issue
@shilman shilman mentioned this pull request Aug 5, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@danielduan danielduan Awaiting requested review from danielduan

@thani-sh thani-sh Awaiting requested review from thani-sh

@usulpro usulpro Awaiting requested review from usulpro

Assignees

@ndelangen ndelangen

Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch performance issue
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ndelangen @shilman