Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addon-storysource: Add source-loader dep to avoid breaking change #7554

Merged
merged 1 commit into from
Jul 25, 2019
Merged

Addon-storysource: Add source-loader dep to avoid breaking change #7554

merged 1 commit into from
Jul 25, 2019

Conversation

shilman
Copy link
Member

@shilman shilman commented Jul 25, 2019

Issue: #7509

What I did

  • Add source-loader dep to avoid breaking change
  • Add deprecation notice

How to test

See official-storybook etc.

@shilman shilman added this to the 5.2.0 milestone Jul 25, 2019
@shilman shilman requested a review from igor-dv as a code owner July 25, 2019 08:49
@vercel
Copy link

vercel bot commented Jul 25, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://monorepo-git-7509-storysource-source-loader.storybook.now.sh

@libetl
Copy link
Member

libetl commented Jul 25, 2019

👍

@libetl libetl self-requested a review July 25, 2019 08:50
libetl
libetl approved these changes Jul 25, 2019
View reviewed changes
Copy link
Member

@libetl libetl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@shilman shilman requested a review from Hypnosphi July 25, 2019 09:00
@shilman shilman merged commit 0de0cb0 into next Jul 25, 2019
@shilman shilman deleted the 7509-storysource-source-loader branch July 25, 2019 10:03
@shilman shilman mentioned this pull request Jul 25, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@libetl libetl libetl approved these changes

@igor-dv igor-dv Awaiting requested review from igor-dv

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

Assignees
No one assigned
Labels
addon: storysource bug
Projects
None yet
Milestone
5.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @libetl