Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon-docs: Add docsContainer parameter #7814

Merged
merged 4 commits into from
Aug 20, 2019
Merged

Conversation

shilman
Copy link
Member

@shilman shilman commented Aug 20, 2019

Issue: #7813 #7810

What I did

How to test

cd examples/official-storybook
yarn storybook

@vercel
Copy link

vercel bot commented Aug 20, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome


addParameters({
docsContainer: DocsContainer,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feel like we should have one parameter for docs and nest things under it :/

@vercel vercel bot temporarily deployed to staging August 20, 2019 06:50 Inactive
@shilman shilman added this to the 5.2.0 milestone Aug 20, 2019
@shilman shilman merged commit 58bf537 into next Aug 20, 2019
@shilman shilman deleted the 7813-docscontainer-parameter branch August 20, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants