-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add/app marionette js #7981
Add/app marionette js #7981
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/fdy0zpysi |
Great work @avasuro -- very exciting! We're just getting 5.2 out the door, so we'll have to wait until that's released to merge this. |
@shilman, thank you! no problem. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add a example for this?
I think yes, for consistency (all other frameworks except react native has examples). But I didn't figured out how to do that. |
@avasuro shall we schedule a pair programming session to finish this? contact me on discord: We need to add an example of a marionette app that has storybook. |
# Conflicts: # lib/cli/package.json # yarn.lock
@avasuro do you think you'd be available to work together on this to get this merged? |
Hi, yes. I will write you in discord. |
# Conflicts: # lib/cli/package.json
Issue: #7980
What I did
Added support of Marionette.js framework
How to test