Addon-docs: Jest MDX transform for storyshots #8189
Conversation
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/storybook/monorepo/bs7viuaag |
|
Can't wait for this either, thanks! Maybe remove the dependency on |
|
Would you like to contribute to this PR @edelgado? |
|
@ndelangen sure thing! Thanks for the access, will submit a commit soon. |
|
@shilman Absolutely! Added to both add-ons to make it easier on the users. |
|
@shilman what do you require? |
|
@ndelangen working with @Hypnosphi to get this mergeable |
|
@shilman looks like you're adding the transform twice, as it's already present in In my case, right before your commit, the html snapshotting went OK, but storyshots-integrity complained, probably because its algorythm doesn't know anything about mdx extension yet The other failures (vue, angular) were the same as you see now on CI UPD: I re-ran the CI tests on my commit, so that you could see the original "Storyshots Integrity" error |
|
@Hypnosphi I fixed the integrity error in my latest commit. However, I'm not sure what's going on with Vue/Angular. Do you have any ideas? |
|
@shilman not really |
|
@ndelangen and I were able to get angular working. Vue is not working due to a babel issue, and I've temporarily disabled it to move this forward. I'll follow up with @Aaron-Pool to see if we can get that working. Pretty sure it's more of a Vue/Babel issue than a Jest/MDX one. |
shilman
changed the title
shilman
changed the title
| ```json | ||
| { | ||
| "transform": { | ||
| "^.+\\.[tj]sx?$": "babel-jest", |
There was a problem hiding this comment.
Isn't there a pipe symbol missing: [t|j] ? As here: https://github.com/facebook/jest/tree/master/packages/babel-jest#setup
| ```json | ||
| { | ||
| "transform": { | ||
| "^.+\\.[tj]sx?$": "babel-jest", |
There was a problem hiding this comment.
Isn't the pipe symbol necessary? [t|j]
Issue: #7223
This replaces #7330 since that PR no longer has a repository and cannot be contributed on anymore :(
What I did
Wrote a jest transform for mdx files.
How to test
add the following to your jest config:
{ "transform": { "^.+\\.[tj]sx?$": "babel-jest", "^.+\\.mdx?$": "@storybook/addon-docs/jest-transform-mdx", } }