Remove weak dependency for Node 12 compat
#8300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://monorepo-git-fix-node-version.storybook.now.sh |
|
I think we could just lazy install the |
|
To give some context about |
|
"some developers" === @ndelangen Just remove the dependency, I'll add it when I need it. |
`node-weak` is not working with Node 12 and so make `yarn bootstrap` command fail. Moreover it is used only for jest related stuff and only affects some developers. The good news is Jest has been working on that and the next release of Jest will certainly get ride of this dependency. See jestjs/jest#8686
gaetanmaisse
force-pushed
the
fix-node-version
branch
from
ea29850 to
9829441
Compare
gaetanmaisse
changed the title
weak dependency from SB
gaetanmaisse
changed the title
weak dependency from SB weak dependency from SB to make it works with Node 12
shilman
changed the title
weak dependency from SB to make it works with Node 12weak dependency for Node 12 compat
Hypnosphi
added
the
patch:yes
Hypnosphi
pushed a commit
that referenced
this pull request
Nov 9, 2019
Hypnosphi
added
the
patch:done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #8002
Context
To give some context about weak dependency, it's used only for jest related stuff and only affects some developers. The good news is Jest has been working on that and the next release of Jest will certainly allow us to remove weak from our deps.
See jestjs/jest#8686
What I did
I removed
weakdependency from SB project.--
OLD DESCRIPTION
This is sadly not a fix for #8002 but a workaround to force dev to use Node <12 as long as the issue with
node-weakis not fixed.What I did
I updated
engineproperty of rootpackage.jsonto force node to be between version 8 and 11 asnode-weakdependency is not working on Node 12: TooTallNate/node-weak#99This node max version can be removed as soon as we found a fix/workaround to
node-weakand Node 12 incompatibility.